fixed #1246 and add unit test

src/targeting.js

@@ -1,4 +1,4 @@
-import { uniques, isGptPubadsDefined, getHighestCpm, adUnitsFilter } from './utils';
+import { uniques, isGptPubadsDefined, getHighestCpm, adUnitsFilter, groupBy } from './utils';
 import { config } from './config';
 import { NATIVE_TARGETING_KEYS } from './native';
 const bidmanager = require('./bidmanager');
@@ -96,13 +96,7 @@ targeting.getWinningBids = function(adUnitCode) {
     .filter(uniques)
     .map(adUnitCode => $$PREBID_GLOBAL$$._bidsReceived
       .filter(bid => bid.adUnitCode === adUnitCode ? bid : null)
-      .reduce(getHighestCpm,
-        {
-          adUnitCode: adUnitCode,
-          cpm: 0,
-          adserverTargeting: {},
-          timeToRespond: 0
-        }));
+      .reduce(getHighestCpm, getEmptyBid(adUnitCode)));
 };
 
 targeting.setTargetingForAst = function() {
@@ -173,19 +167,24 @@ function getAlwaysUseBidTargeting(adUnitCodes) {
 
 function getBidLandscapeTargeting(adUnitCodes) {
   const standardKeys = CONSTANTS.TARGETING_KEYS.concat(NATIVE_TARGETING_KEYS);
-
-  return $$PREBID_GLOBAL$$._bidsReceived
-    .filter(adUnitsFilter.bind(this, adUnitCodes))
-    .map(bid => {
-      if (bid.adserverTargeting) {
-        return {
-          [bid.adUnitCode]: getTargetingMap(bid, standardKeys.filter(
-            key => typeof bid.adserverTargeting[key] !== 'undefined') // mainly for possibly
-            // unset hb_deal
-          )
-        };
-      }
-    }).filter(bid => bid); // removes empty elements in array
+  const bids = [];
+  // bucket by adUnitcode
+  let buckets = groupBy($$PREBID_GLOBAL$$._bidsReceived, 'adUnitCode');
+  // filter top bid for each bucket by bidder
+  Object.keys(buckets).forEach(bucketKey => {
+    let bidsByBidder = groupBy(buckets[bucketKey], 'bidderCode');
+    Object.keys(bidsByBidder).forEach(key => bids.push(bidsByBidder[key].reduce(getHighestCpm, getEmptyBid())));
+  });
+  // populate targeting keys for the remaining bids
+  return bids.map(bid => {
+    if (bid.adserverTargeting) {
+      return {
+        [bid.adUnitCode]: getTargetingMap(bid, standardKeys.filter(
+          key => typeof bid.adserverTargeting[key] !== 'undefined')
+        )
+      };
+    }
+  }).filter(bid => bid); // removes empty elements in array
 }
 
 function getTargetingMap(bid, keys) {
@@ -201,3 +200,12 @@ targeting.isApntagDefined = function() {
     return true;
   }
 };
+
+function getEmptyBid(adUnitCode) {
+  return {
+    adUnitCode: adUnitCode,
+    cpm: 0,
+    adserverTargeting: {},
+    timeToRespond: 0
+  };
+}

src/utils.js

@@ -666,3 +666,18 @@ export function getBidderRequest(bidder, adUnitCode) {
       .filter(bid => bid.bidder === bidder && bid.placementCode === adUnitCode).length > 0;
   }) || { start: null, requestId: null };
 }
+
+/**
+ *
+ * https://stackoverflow.com/a/34890276/428704
+ * @export
+ * @param {array} xs
+ * @param {string} key
+ * @returns {${key_value}: ${groupByArray}, key_value: {groupByArray}}
+ */
+export function groupBy(xs, key) {
+  return xs.reduce(function(rv, x) {
+    (rv[x[key]] = rv[x[key]] || []).push(x);
+    return rv;
+  }, {});
+}

test/spec/unit/core/targeting_spec.js

@@ -0,0 +1,99 @@
+import { expect } from 'chai';
+import Targeting from 'src/targeting';
+import { config } from 'src/config';
+import { getAdUnits } from 'test/fixtures/fixtures';
+import CONSTANTS from 'src/constants.json';
+
+const bid1 = {
+  'bidderCode': 'rubicon',
+  'width': '300',
+  'height': '250',
+  'statusMessage': 'Bid available',
+  'adId': '148018fe5e',
+  'cpm': 0.537234,
+  'ad': 'markup',
+  'ad_id': '3163950',
+  'sizeId': '15',
+  'requestTimestamp': 1454535718610,
+  'responseTimestamp': 1454535724863,
+  'timeToRespond': 123,
+  'pbLg': '0.50',
+  'pbMg': '0.50',
+  'pbHg': '0.53',
+  'adUnitCode': '/123456/header-bid-tag-0',
+  'bidder': 'rubicon',
+  'size': '300x250',
+  'adserverTargeting': {
+    'hb_bidder': 'rubicon',
+    'hb_adid': '148018fe5e',
+    'hb_pb': '0.53',
+    'foobar': '300x250'
+  }
+};
+
+const bid2 = {
+  'bidderCode': 'rubicon',
+  'width': '300',
+  'height': '250',
+  'statusMessage': 'Bid available',
+  'adId': '5454545',
+  'cpm': 0.25,
+  'ad': 'markup',
+  'ad_id': '3163950',
+  'sizeId': '15',
+  'requestTimestamp': 1454535718610,
+  'responseTimestamp': 1454535724863,
+  'timeToRespond': 123,
+  'pbLg': '0.25',
+  'pbMg': '0.25',
+  'pbHg': '0.25',
+  'adUnitCode': '/123456/header-bid-tag-0',
+  'bidder': 'rubicon',
+  'size': '300x250',
+  'adserverTargeting': {
+    'hb_bidder': 'rubicon',
+    'hb_adid': '5454545',
+    'hb_pb': '0.25',
+    'foobar': '300x250'
+  }
+};
+
+describe('targeting tests', () => {
+  describe('getAllTargeting', () => {
+    beforeEach(() => {
+      $$PREBID_GLOBAL$$._sendAllBids = false;
+      $$PREBID_GLOBAL$$._bidsReceived = [];
+      $$PREBID_GLOBAL$$._adUnitCodes = [];
+      $$PREBID_GLOBAL$$.adUnits = [];
+    });
+
+    it('selects the top bid when _sendAllBids true', () => {
+      $$PREBID_GLOBAL$$.adUnits = [{
+        code: '/123456/header-bid-tag-0',
+        sizes: [300, 250],
+        bids: [
+          {
+            'bidder': 'rubicon',
+            'params': {
+              'accountId': 10617,
+              'siteId': 23635,
+              'zoneId': 453908
+            }
+          }
+        ]
+      }];
+      config.setConfig({ enableSendAllBids: true });
+      $$PREBID_GLOBAL$$._bidsReceived.push(bid1, bid2);
+      $$PREBID_GLOBAL$$._adUnitCodes = ['/123456/header-bid-tag-0'];
+      let targeting = Targeting.getAllTargeting(['/123456/header-bid-tag-0']);
+      let flattened = [];
+      targeting.filter(obj => obj['/123456/header-bid-tag-0'] !== undefined).forEach(item => flattened = flattened.concat(item['/123456/header-bid-tag-0']));
+      let sendAllBidCpm = flattened.filter(obj => obj.hb_pb_rubicon !== undefined);
+      let winningBidCpm = flattened.filter(obj => obj.hb_pb !== undefined);
+      // we shouldn't get more than 1 key for hb_pb_${bidder}
+      expect(sendAllBidCpm.length).to.equal(1);
+      // expect the winning CPM to be equal to the sendAllBidCPM
+      expect(sendAllBidCpm[0]['hb_pb_rubicon']).to.deep.equal(winningBidCpm[0]['hb_pb']);
+    });
+  }); // end getAllTargeting tests
+});