Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carambola header bidding adaptor (fix)- changing the server url. #1468

Merged
merged 2 commits into from
Aug 10, 2017
Merged

Carambola header bidding adaptor (fix)- changing the server url. #1468

merged 2 commits into from
Aug 10, 2017

Conversation

LiranMotola
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Carambola header bidding adaptor - changing the server url (2).

Be sure to test the integration with your adserver using the Hello World sample page.

jaiminpanchal27
jaiminpanchal27 approved these changes Aug 8, 2017
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbemiller dbemiller merged commit 4e3dc09 into prebid:master Aug 10, 2017
philipwatson pushed a commit to mbrtargeting/Prebid.js that referenced this pull request Sep 18, 2017
@LiranMotola @philipwatson
Carambola header bidding adaptor (fix)- changing the server url. (pre…
ebb8321 
…bid#1468)

* Carambola header bidding adaptor (fix)- changing the server url.

* carambolaBidAdapter_spec following a change in the path
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@LiranMotola @jbAdyoulike
Carambola header bidding adaptor (fix)- changing the server url. (pre…
7239d47 
…bid#1468)

* Carambola header bidding adaptor (fix)- changing the server url.

* carambolaBidAdapter_spec following a change in the path
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@LiranMotola @dluxemburg
Carambola header bidding adaptor (fix)- changing the server url. (pre…
ce4f1d3 
…bid#1468)

* Carambola header bidding adaptor (fix)- changing the server url.

* carambolaBidAdapter_spec following a change in the path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiranMotola @jaiminpanchal27 @dbemiller