[Criteo Adapter] Use utils lib to parse request sizes #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiiip
force-pushed
the
criteo-parseSize
branch
2 times, most recently
from
982beb1
to
40a201f
Compare
Swiiip
force-pushed
the
criteo-parseSize
branch
from
40a201f
to
80a1a74
Compare
mkendall07
approved these changes
Aug 7, 2017
muuki88
reviewed
Aug 8, 2017
| var xIndex = sizeString.indexOf('x'); | ||
| var w = parseInt(sizeString.substring(0, xIndex)); | ||
| var h = parseInt(sizeString.substring(xIndex + 1, sizeString.length)) | ||
| return new Criteo.PubTag.DirectBidding.Size(w, h); |
There was a problem hiding this comment.
What effect has this change? We are currently sending all our ad slot sizes,
but were told that the backend doesn't use them anyway. Will this change
in the future?
There was a problem hiding this comment.
Yes, this will change in the future, we will need this size information to handle the request on our end.
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR formats the request sizes in Criteo adapter. As those sizes are not formatted, we need to format them before using them in a consistent manner.