Audience Network: ensure pageurl is always URI encoded #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Aug 25, 2017
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
|
Looks like this fix was reverted in 403a991#diff-97dadabd4d374d37991cffac1d050d0f |
|
@andyblackwell Ah yes, the upgrade to the Prebid 1.0 API involved a pretty big change that also had to involve refactoring unit tests and this one got lost. If you're able to submit a PR for this I'd be happy to review. |
Merged
8 tasks
|
@andyblackwell This is covered by PR #1873, thanks for reporting. |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hello, this is a fix for #1497 that ensures
pageurlis correctly URI encoded before calling Prebid's URLformatfunction.It also adds test expectations to verify this behaviour.
This work was commissioned and paid for by Facebook.