Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AerServ Adapter #1538

Merged
merged 9 commits into from
Aug 31, 2017
Merged

Add AerServ Adapter #1538

merged 9 commits into from
Aug 31, 2017

Conversation

cormorinth
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Adding the AerServ bid adapter

  • test parameters for validating bids
{
  bidder: 'aerserv',
  params: {
    plc: '480'
  }
}

Other information

@jaiminpanchal27 jaiminpanchal27 self-assigned this Aug 29, 2017
jaiminpanchal27
jaiminpanchal27 approved these changes Aug 29, 2017
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @envision753 Very nice code.

@cormorinth cormorinth mentioned this pull request Aug 30, 2017
Merged
@matthewlane matthewlane self-requested a review August 31, 2017 17:26
@matthewlane matthewlane self-assigned this Aug 31, 2017
@matthewlane matthewlane merged commit 1fd757a into prebid:master Aug 31, 2017
ptomasroos pushed a commit to happypancake/Prebid.js that referenced this pull request Sep 1, 2017
@cormorinth @ptomasroos
Add AerServ Adapter (prebid#1538)
732b5a6 
* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* feature necromancy! post-merge fixes to account for new structure

* last minute addition of some video parameter logic + some name refactoring
philipwatson pushed a commit to mbrtargeting/Prebid.js that referenced this pull request Sep 18, 2017
@cormorinth @philipwatson
Add AerServ Adapter (prebid#1538)
cbd71a1 
* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* feature necromancy! post-merge fixes to account for new structure

* last minute addition of some video parameter logic + some name refactoring
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Sep 18, 2017
Merge tag '0.28.0' of https://github.com/prebid/Prebid.js into prebuilt
da960cc 
* tag '0.28.0' of https://github.com/prebid/Prebid.js: (27 commits)
  Prebid 0.28.0 Release
  Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563)
  add () for correct order of operations in scaling increments for currency (prebid#1559)
  AppnexusAst adapter update: Added source and version to request payload (prebid#1555)
  remove unnecessary spread operator (prebid#1561)
  Adxcg adapter (prebid#1554)
  Upgrade sinon to 3.x (prebid#1491)
  Rename vastPayload to vastXml (prebid#1556)
  Single-size sizes array now can be taken, too (prebid#1535)
  Updated the istanbul-instrumenter-loader (prebid#1550)
  Add AerServ Adapter (prebid#1538)
  Fixed imports and made adform support aliasing (prebid#1518)
  Custom granularity fix (prebid#1546)
  Fix `documentation lint` issues (prebid#1544)
  Yieldbot adunit bidder params slot name usage fix (prebid#1394)
  Update serverbid adapter to use smartsync (prebid#1324)
  Add improvedigitalBidAdapter (prebid#1381)
  Fix prebid#1533 spring server typo (prebid#1542)
  userSync is off by default (prebid#1543)
  currency module (prebid#1374)
  ...
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@cormorinth @jbAdyoulike
Add AerServ Adapter (prebid#1538)
5d8a2fa 
* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* feature necromancy! post-merge fixes to account for new structure

* last minute addition of some video parameter logic + some name refactoring
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Oct 12, 2017
@vzhukovsky
Merge pull request prebid#121 in AOLP_ADS_JS/prebid.js from release/1…
e797d03 
….28.0 to aolgithub-master

* commit '4d9ade3df767750743f8888ed9efd6c77f8d0050': (26 commits)
  Added changelog entry.
  Added new aol partners ids.
  Prebid 0.28.0 Release
  Revert "Upgrade sinon to 3.x (prebid#1491)" (prebid#1563)
  add () for correct order of operations in scaling increments for currency (prebid#1559)
  AppnexusAst adapter update: Added source and version to request payload (prebid#1555)
  remove unnecessary spread operator (prebid#1561)
  Adxcg adapter (prebid#1554)
  Upgrade sinon to 3.x (prebid#1491)
  Rename vastPayload to vastXml (prebid#1556)
  Single-size sizes array now can be taken, too (prebid#1535)
  Updated the istanbul-instrumenter-loader (prebid#1550)
  Add AerServ Adapter (prebid#1538)
  Fixed imports and made adform support aliasing (prebid#1518)
  Custom granularity fix (prebid#1546)
  Fix `documentation lint` issues (prebid#1544)
  Yieldbot adunit bidder params slot name usage fix (prebid#1394)
  Update serverbid adapter to use smartsync (prebid#1324)
  Add improvedigitalBidAdapter (prebid#1381)
  Fix prebid#1533 spring server typo (prebid#1542)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@cormorinth @dluxemburg
Add AerServ Adapter (prebid#1538)
6c2baae 
* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* implemented AerServ adapter

* added unit tests, slight refactor/formatting of adapter code, added to adapters json

* feature necromancy! post-merge fixes to account for new structure

* last minute addition of some video parameter logic + some name refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@matthewlane matthewlane

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cormorinth @matthewlane @jaiminpanchal27