Tremor Video Bid Adapter #1552
Tremor Video Bid Adapter #1552
Conversation
…with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url.
modules/tremorBidAdapter.js
Outdated
| bid.crid = response.crid; | ||
| bid.vastXml = response.adm; | ||
| // This is a dummy vast URL, Tremor sends back the vast XML (the line above). | ||
| bid.vastUrl = 'http://cdn.tremorhub.com/static/dummy.xml'; |
There was a problem hiding this comment.
Bid responses with a vastXml property will now pass validation with #1556 in master, so if Tremor sends xml and not a vast url, this line can be dropped
| @@ -1945,7 +1945,7 @@ d@1: | |||
| dependencies: | |||
| es5-ext "^0.10.9" | |||
|
|
|||
| "dargs@github:christian-bromann/dargs": | |||
| dargs@christian-bromann/dargs: | |||
There was a problem hiding this comment.
This doesn't look intentional... not sure why it changed?
There was a problem hiding this comment.
Running yarn install on current master resulted in this update to the lockfile for me too. I tried deleting node_modules then yarn install again with this changed lockfile and things still build out properly
There was a problem hiding this comment.
ahh... common mistake. I ran into this recently, and it's just a weird API on their part.
yarn install pulls the latest dependencies which package.json allows. This might change your yarn.lock, if someone released a new version of a package recently.
yarn install --pure-lockfile installs the dependencies from yarn.lock without changing them.
Very unlikely to do any real harm, though.
Type of change
Description of change
Tremor video bid adapter.
Other information