Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSDoc for setConfig #1579

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Improve JSDoc for setConfig #1579

merged 1 commit into from
Sep 22, 2017

Conversation

rmloveland
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Update the JSDoc on the setConfig method to bring it to ~parity with the existing API docs on Prebid.org.

Other information

Climbing the mountain of #1408 :-)

Specifically, brings it to ~parity with the existing API docs on
Prebid.org.
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@mkendall07 mkendall07 merged commit 74e5f9f into master Sep 22, 2017
@mkendall07 mkendall07 deleted the docs-setConfig branch September 22, 2017 02:34
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Specifically, brings it to ~parity with the existing API docs on
Prebid.org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants