Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenX Adapter: 1) changing custom parameters to be on a per-slot basis #1596

Merged
merged 1 commit into from
Sep 27, 2017
Merged

OpenX Adapter: 1) changing custom parameters to be on a per-slot basis #1596

merged 1 commit into from
Sep 27, 2017

Conversation

lntho
Copy link
Contributor

@lntho lntho commented Sep 18, 2017

  1. Add ability to specify custom floors per slot
  2. Change BC parameter to be configurable
  3. Give ability to turn off building BO pixels given a flag

Type of change

  • [ x ] Bugfix
  • [ x ] Feature

Description of change

  • test parameters for validating bids
    OpenX Adapter:
  1. changing custom parameters to be on a per-slot basis
  2. Add ability to specify custom floors per slot
  3. Change BC parameter to be configurable
  4. Give ability to turn off building BO pixels given a flag

Other information

OpenX Adapter: 1) changing custom parameters to be on a per-slot basis
73e1de7 
2) Add ability to specify custom floors per slot

3) Change BC parameter to be configurable

4) Give ability to turn off building BO pixels given a flag
@matthewlane matthewlane self-requested a review September 20, 2017 17:23
@matthewlane matthewlane self-assigned this Sep 20, 2017
@matthewlane matthewlane assigned ndhimehta and unassigned matthewlane Sep 21, 2017
@snapwich snapwich self-requested a review September 27, 2017 16:01
snapwich
snapwich approved these changes Sep 27, 2017
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewlane matthewlane merged commit 16d5dd4 into prebid:master Sep 27, 2017
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@lntho @dluxemburg
OpenX adapter: 1) changing custom parameters to be on a per-slot basis (
648b9af 
prebid#1596)

2) Add ability to specify custom floors per slot

3) Change BC parameter to be configurable

4) Give ability to turn off building BO pixels given a flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

@ndhimehta ndhimehta

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lntho @snapwich @matthewlane @ndhimehta