-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GetIntent adapter to 1.0 version #1721
Changes from 3 commits
3a332fa
6d22ab4
d5c27ee
53c946f
359c16a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,78 +1,130 @@ | ||
import { STATUS } from 'src/constants'; | ||
import adaptermanager from 'src/adaptermanager'; | ||
import { registerBidder } from 'src/adapters/bidderFactory'; | ||
|
||
var bidfactory = require('src/bidfactory.js'); | ||
var bidmanager = require('src/bidmanager.js'); | ||
var adloader = require('src/adloader.js'); | ||
const BIDDER_CODE = 'getintent'; | ||
const BID_HOST = 'px.adhigh.net'; | ||
const BID_BANNER_PATH = '/rtb/direct_banner'; | ||
const BID_VIDEO_PATH = '/rtb/direct_vast'; | ||
const VIDEO_PROPERTIES = [ | ||
'protocols', 'mimes', 'min_dur', 'max_dur', 'min_btr', 'max_btr', 'vi_format', 'api', 'skippable' | ||
]; | ||
const OPTIONAL_PROPERTIES = [ | ||
'cur', 'floor' | ||
]; | ||
|
||
var GetIntentAdapter = function GetIntentAdapter() { | ||
var headerBiddingStaticJS = window.location.protocol + '//cdn.adhigh.net/adserver/hb.js'; | ||
export const spec = { | ||
code: BIDDER_CODE, | ||
aliases: ['getintentAdapter'], | ||
supportedMediaTypes: ['video', 'banner'], | ||
|
||
function _callBids(params) { | ||
if (typeof window.gi_hb === 'undefined') { | ||
adloader.loadScript(headerBiddingStaticJS, function() { | ||
bid(params); | ||
}, true); | ||
} else { | ||
bid(params); | ||
/** | ||
* Determines whether or not the given bid request is valid. | ||
* | ||
* @param {BidRequest} bid The bid to validate. | ||
* @return {boolean} True if this is a valid bid, and false otherwise. | ||
* */ | ||
isBidRequestValid: function(bid) { | ||
return !!(bid && bid.params && bid.params.pid && bid.params.tid); | ||
}, | ||
|
||
/** | ||
* Make a server request from the list of BidRequests. | ||
* | ||
* @param {BidRequest[]} bidRequests - an array of bids. | ||
* @return ServerRequest[] | ||
*/ | ||
buildRequests: function(bidRequests) { | ||
return bidRequests.map(bidRequest => { | ||
let giBidRequest = buildGiBidRequest(bidRequest); | ||
return { | ||
method: 'GET', | ||
url: buildUrl(giBidRequest), | ||
data: giBidRequest, | ||
}; | ||
}); | ||
}, | ||
|
||
/** | ||
* Callback for bids, after the call to DSP completes. | ||
* Parse the response from the server into a list of bids. | ||
* | ||
* @param {object} serverResponse A response from the server. | ||
* @param {BidRequest} bidRequest | ||
* @return {Bid[]} An array of bids which were nested inside the server. | ||
*/ | ||
interpretResponse: function(serverResponse, bidRequest) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #1748 changed the first argument of {
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
} so doing something like serverResponse = serverResponse.body (or however you'd prefer) in this function should give you the expected behavior |
||
const bids = []; | ||
if (serverResponse && serverResponse.no_bid !== 1) { | ||
let size = parseSize(serverResponse.size); | ||
let bid = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few of the required bid response fields are missing: |
||
requestId: bidRequest.bidId, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
bidderCode: spec.code, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
cpm: serverResponse.cpm, | ||
width: size[0], | ||
height: size[1], | ||
mediaType: bidRequest.mediaType || 'banner' | ||
}; | ||
if (bidRequest.creative_id) bid.creativeId = bidRequest.creative_id; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is your endpoint able to always return a |
||
if (bidRequest.mediaType === 'video') { | ||
bid.vastUrl = serverResponse.vast_url; | ||
bid.descriptionUrl = serverResponse.vast_url; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} else { | ||
bid.ad = serverResponse.ad; | ||
} | ||
bids.push(bid); | ||
} | ||
return bids; | ||
} | ||
|
||
function addOptional(params, request, props) { | ||
for (var i = 0; i < props.length; i++) { | ||
if (params.hasOwnProperty(props[i])) { | ||
request[props[i]] = params[props[i]]; | ||
} | ||
|
||
function buildUrl(bid) { | ||
return '//' + BID_HOST + (bid.is_video ? BID_VIDEO_PATH : BID_BANNER_PATH); | ||
} | ||
|
||
/** | ||
* Builds GI bid request from BidRequest. | ||
* | ||
* @param {BidRequest} bidRequest. | ||
* @return {object} GI bid request. | ||
* */ | ||
function buildGiBidRequest(bidRequest) { | ||
let giBidRequest = { | ||
pid: bidRequest.params.pid, // required | ||
tid: bidRequest.params.tid, // required | ||
known: bidRequest.params.known || 1, | ||
is_video: bidRequest.mediaType === 'video', | ||
resp_type: 'JSON' | ||
}; | ||
if (bidRequest.sizes) { | ||
// TODO: add support for multiple sizes | ||
giBidRequest.size = bidRequest.sizes[0].join('x'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adunit sizes may be defined as |
||
} | ||
addVideo(bidRequest.params.video, giBidRequest); | ||
addOptional(bidRequest.params, giBidRequest, OPTIONAL_PROPERTIES); | ||
return giBidRequest; | ||
} | ||
|
||
function addVideo(video, giBidRequest) { | ||
if (giBidRequest.is_video && video) { | ||
for (let i = 0, l = VIDEO_PROPERTIES.length; i < l; i++) { | ||
let key = VIDEO_PROPERTIES[i]; | ||
if (video.hasOwnProperty(key)) { | ||
giBidRequest[key] = Array.isArray(video[key]) ? video[key].join(',') : video[key]; | ||
} | ||
} | ||
} | ||
} | ||
|
||
function bid(params) { | ||
var bids = params.bids || []; | ||
for (var i = 0; i < bids.length; i++) { | ||
var bidRequest = bids[i]; | ||
var request = { | ||
pid: bidRequest.params.pid, // required | ||
tid: bidRequest.params.tid, // required | ||
known: bidRequest.params.known || 1, | ||
is_video: bidRequest.mediaType === 'video', | ||
video: bidRequest.params.video || {}, | ||
size: bidRequest.sizes[0].join('x'), | ||
}; | ||
addOptional(bidRequest.params, request, ['cur', 'floor']); | ||
(function (r, br) { | ||
window.gi_hb.makeBid(r, function(bidResponse) { | ||
if (bidResponse.no_bid === 1) { | ||
var nobid = bidfactory.createBid(STATUS.NO_BID); | ||
nobid.bidderCode = br.bidder; | ||
bidmanager.addBidResponse(br.placementCode, nobid); | ||
} else { | ||
var bid = bidfactory.createBid(STATUS.GOOD); | ||
var size = bidResponse.size.split('x'); | ||
bid.bidderCode = br.bidder; | ||
bid.cpm = bidResponse.cpm; | ||
bid.width = size[0]; | ||
bid.height = size[1]; | ||
if (br.mediaType === 'video') { | ||
bid.vastUrl = bidResponse.vast_url; | ||
bid.descriptionUrl = bidResponse.vast_url; | ||
bid.mediaType = 'video'; | ||
} else { | ||
bid.ad = bidResponse.ad; | ||
} | ||
bidmanager.addBidResponse(br.placementCode, bid); | ||
} | ||
}); | ||
})(request, bidRequest); | ||
function addOptional(params, request, props) { | ||
for (let i = 0; i < props.length; i++) { | ||
if (params.hasOwnProperty(props[i])) { | ||
request[props[i]] = params[props[i]]; | ||
} | ||
} | ||
} | ||
|
||
return { | ||
callBids: _callBids | ||
}; | ||
}; | ||
|
||
adaptermanager.registerBidAdapter(new GetIntentAdapter(), 'getintent', { | ||
supportedMediaTypes: ['video'] | ||
}); | ||
function parseSize(s) { | ||
return s.split('x').map(Number); | ||
} | ||
|
||
module.exports = GetIntentAdapter; | ||
registerBidder(spec); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Overview | ||
|
||
``` | ||
Module Name: GetIntent Bidder Adapter | ||
Module Type: Bidder Adapter | ||
Maintainer: server-dev@getintent.com | ||
``` | ||
|
||
# Description | ||
|
||
Module that connects to GetIntent's demand sources. | ||
Banner and Video formats are supported. | ||
|
||
# Required parameters | ||
* ```pid``` for Publisher ID | ||
* ```tid``` for Tag ID. | ||
|
||
# Test Parameters | ||
``` | ||
var adUnits = [ | ||
{ | ||
code: 'test-ad', | ||
sizes: [[300, 250]], | ||
bids: [ | ||
{ | ||
bidder: "getintent", | ||
params: { | ||
pid: "12345", | ||
tid: "9876" | ||
} | ||
} | ||
] | ||
},{ | ||
code: 'test-video-ad', | ||
sizes: [[300, 250]], | ||
bids: [ | ||
{ | ||
bidder: "getintent", | ||
params: { | ||
pid: "12345", | ||
tid: "9876" | ||
}, | ||
mediaType: "video" | ||
} | ||
] | ||
} | ||
]; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should set
bidId: bidRequest.bidId
so that theinterpretResponse
function has access to it