Sovrn 1.0 compliance #1796
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,156 +1,82 @@ | ||
| import * as utils from 'src/utils'; | ||
| import { registerBidder } from 'src/adapters/bidderFactory'; | ||
| import { BANNER } from 'src/mediaTypes'; | ||
| import { REPO_AND_VERSION } from 'src/constants'; | ||
|
|
||
| export const spec = { | ||
| code: 'sovrn', | ||
| supportedMediaTypes: [BANNER], | ||
|
|
||
| /** | ||
| * Check if the bid is a valid zone ID in either number or string form | ||
| * @param {object} bid the Sovrn bid to validate | ||
| * @return boolean for whether or not a bid is valid | ||
| */ | ||
| isBidRequestValid: function(bid) { | ||
| return !!(bid.params.tagid && !isNaN(parseFloat(bid.params.tagid)) && isFinite(bid.params.tagid)); | ||
| }, | ||
|
|
||
| /** | ||
| * Format the bid request object for our endpoint | ||
| * @param {BidRequest[]} bidRequests Array of Sovrn bidders | ||
| * @return object of parameters for Prebid AJAX request | ||
| */ | ||
| buildRequests: function(bidReqs) { | ||
| let sovrnImps = []; | ||
| utils._each(bidReqs, function (bid) { | ||
| sovrnImps.push({ | ||
| id: bid.bidId, | ||
| banner: { w: 1, h: 1 }, | ||
| tagid: utils.getBidIdParameter('tagid', bid.params), | ||
| bidfloor: utils.getBidIdParameter('bidfloor', bid.params) | ||
| }); | ||
| }); | ||
| const sovrnBidReq = { | ||
| id: utils.getUniqueIdentifierStr(), | ||
| imp: sovrnImps, | ||
| site: { | ||
| domain: window.location.host, | ||
| page: window.location.pathname + location.search + location.hash | ||
| } | ||
| }; | ||
| return { | ||
| method: 'POST', | ||
| url: `//ap.lijit.com/rtb/bid?src=${REPO_AND_VERSION}`, | ||
| data: JSON.stringify(sovrnBidReq), | ||
| options: {contentType: 'text/plain'} | ||
| }; | ||
| }, | ||
|
|
||
| /** | ||
| * Format Sovrn responses as Prebid bid responses | ||
| * @param {id, seatbid} sovrnResponse A successful response from Sovrn. | ||
| * @return {Bid[]} An array of formatted bids. | ||
| */ | ||
| interpretResponse: function({ body: {id, seatbid} }) { | ||
| let sovrnBidResponses = []; | ||
| if (id && | ||
| seatbid && | ||
| seatbid.length > 0 && | ||
| seatbid[0].bid && | ||
| seatbid[0].bid.length > 0) { | ||
| seatbid[0].bid.map(sovrnBid => { | ||
| sovrnBidResponses.push({ | ||
| requestId: sovrnBid.impid, | ||
| cpm: parseFloat(sovrnBid.price), | ||
| width: parseInt(sovrnBid.w), | ||
| height: parseInt(sovrnBid.h), | ||
| creativeId: sovrnBid.id, | ||
| dealId: sovrnBid.dealId || null, | ||
| currency: 'USD', | ||
| netRevenue: true, | ||
| mediaType: BANNER, | ||
| ad: decodeURIComponent(`${sovrnBid.adm}<img src="${sovrnBid.nurl}">`), | ||
| ttl: 60000 | ||
| }); | ||
| }); | ||
| } | ||
| return sovrnBidResponses; | ||
| } | ||
| }; | ||
|
|
||
| registerBidder(spec); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Overview | ||
|
|
||
| ``` | ||
| Module Name: Sovrn Bid Adapter | ||
| Module Type: Bidder Adapter | ||
| Maintainer: trand@sovrn.com | ||
| ``` | ||
|
|
||
| # Description | ||
|
|
||
| Sovrn's adapter integration to the Prebid library. Posts plain-text JSON to the /rtb/bid endpoint. | ||
|
|
||
| # Test Parameters | ||
|
|
||
|
There was a problem hiding this comment. This line and line 46 should mark the code with ``` |
||
| ``` | ||
| var adUnits = [ | ||
| { | ||
| code: 'test-leaderboard', | ||
| sizes: [[728, 90]], | ||
| bids: [{ | ||
| bidder: 'sovrn', | ||
| params: { | ||
| tagid: '403370', | ||
| bidfloor: 0.01 | ||
| } | ||
| }] | ||
| }, { | ||
| code: 'test-banner', | ||
| sizes: [[300, 250]], | ||
| bids: [{ | ||
| bidder: 'sovrn', | ||
| params: { | ||
| tagid: '403401' | ||
| } | ||
| }] | ||
| }, { | ||
| code: 'test-sidebar', | ||
| size: [[160, 600]], | ||
| bids: [{ | ||
| bidder: 'sovrn', | ||
| params: { | ||
| tagid: '531000' | ||
| } | ||
| }] | ||
| } | ||
| ] | ||
| ``` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tedrand Is this hardcoded as 1x1 because Sovrn knows the size based on the ID? It seems like the bid.sizes and bid.params.sizes properties will be totally ignored by the adapter. Is that correct?
@mkendall07 If that’s the case, then https://github.com/prebid/Prebid.js/blob/master/modules/sovrnBidAdapter.md should be updated to omit the sizes fields, right?