Prebid 1.0 prebid server #1846

snapwich · 2017-11-16T22:33:58Z

Type of change

Refactoring (no functional changes, no api changes)

Description of change

This is an update of the prebidServerBidAdapter and s2sTesting modules to be 1.0 compliant.

Some of this changed the interface of the prebidServerBidAdapter to be more like a regular bidAdapter (the queueSync and setConfig methods were removed in favor of pbjs.setConfig (which calls queueSync as well)), and the adapter.callBids method was extended to expect additional arguments (a bidRequests array, addBidResponse function, done function, and ajax helper). So while there were no changes to the public API, there were changes to internal API which could affect other submissions, such as other server adapters.

Let me know if you have any questions or comments on how those internal APIs were changed.

(cherry picked from commit 2b843d0)

mkendall07 · 2017-11-20T22:35:49Z

test/spec/unit/pbjs_api_spec.js

-      assert.ok(logErrorSpy.calledOnce, true);
-    });
-  });
+  // describe('setS2SConfig', () => {


are these tests failing or should just be removed altogether?

will move them to prebidServerBidAdapter_spec.js

mkendall07 · 2017-11-21T16:01:37Z

modules/prebidServerBidAdapter.js

+          if (bid.params[key]) {
+            const converted = types[key](bid.params[key]);
+            if (converted !== bid.params[key]) {
+              utils.logMessage(`Mismatched type for Prebid Server : ${bid.bidder} : ${key}. Required Type:${types[key]}`);


let's remove this message. It doesn't serve any real purpose.

mkendall07 · 2017-11-21T16:03:03Z

modules/prebidServerBidAdapter.js

+  },
+};
+
+let _cookiesQueued = false;


it doesn't look like value ever changes. Is it needed?

mkendall07 · 2017-11-21T16:04:51Z

modules/prebidServerBidAdapter.js

+          });
+        }
+
+        // const receivedBidIds = result.bids ? result.bids.map(bidObj => bidObj.bid_id) : [];


dead code can be removed

mkendall07 · 2017-11-21T17:53:30Z

This LGTM with a few minor updates. @harpere can you push updates for those items while Rich is out?

jaiminpanchal27

@snapwich @harpere
Left some comments.
Tested with https://jsfiddle.net/oy3mzh4p/
I do not see any s2s request in network tab.

jaiminpanchal27 · 2017-11-21T20:12:44Z

modules/prebidServerBidAdapter.js

+
+let _s2sConfigDefaults = {
+  enabled: false,
+  endpoint: CONSTANTS.S2S.DEFAULT_ENDPOINT,


These constants are not defined in constants.json

As mentioned elsewhere we should leave the endpoint defaults blank, and probably just hard code the adapter, either here or in config.js like was mentioned in another comment.

jaiminpanchal27 · 2017-11-21T20:14:28Z

src/config.js

@@ -22,16 +22,6 @@ const DEFAULT_USERSYNC = {
  syncDelay: 3000
 };
 const DEFAULT_TIMEOUTBUFFER = 200;
-const DEFAULT_S2SCONFIG = {


Shouldn't we keep default values here in this file ?
How will other s2s adapters get default values ? Like this guy #1819

Makes sense to me @jaiminpanchal27, but want to let @snapwich weigh in before changing it.

Also, we shouldn't have real defaults for endpoint and syncEndpoint. We should be bidder agnostic.

possibly in 1.0. If we omit them now it will break publishers integrations.

I figured the adapters would specify their defaults. Do we want to constrain server adapters to the same configuration? We could, but I assumed we'd let each server adapter behave how it wished, as well as encapsulate as much code as possible inside the module as to not pollute the prebid-core w/ stuff related to a specific module.

yeah I'm ok with each server adapter specifying it's own defaults.

jaiminpanchal27 · 2017-11-21T20:43:59Z

src/adaptermanager.js

+  let [clientBidRequests, serverBidRequests] = bidRequests.reduce((partitions, bidRequest) => {
+    partitions[Number(typeof bidRequest.src !== 'undefined' && bidRequest.src === CONSTANTS.S2S.SRC)].push(bidRequest);
+    return partitions;
+  }, [[], []]);

  if (serverBidRequests.length) {
    let adaptersServerSide = _s2sConfig.bidders;


_s2sConfig is not having any default values here. I am getting below object

{ "enabled": true, "bidders": [ "appnexusAst" ], "accountId": "<some-id>" }

I tested with this test page

@snapwich
Did you check this? Jaimin said it was broken for him when he tested.

just tested with the latest and I seem to be getting the defaults. I'll push the few changes I have and see if that helps, but I think it should have been working before as well.

…ID_REQUEST-event s2s requests now firing BID_REQUESTED event

harpere · 2017-11-22T17:33:09Z

modules/prebidServerBidAdapter.js

+const getConfig = config.getConfig;
+
+const TYPE = S2S.SRC;
+const cookieSetUrl = 'https://acdn.adnxs.com/cookieset/cs.js';


this should be bidder agnostic, so shouldn't hard code it.

yeah probably want to add it to the S2S options.

adding a property called 'cookieSetUrl'

harpere · 2017-11-22T17:40:24Z

@mkendall07 made your suggested changes, but want to let @snapwich weigh in on @jaiminpanchal27's comments

snapwich · 2017-11-27T23:36:31Z

updated

snapwich · 2017-11-28T17:50:49Z

I added an API for modules to be able to set defaults for config settings. It's similar to setConfig except we don't want subscribers notified when we are just settings defaults.

* Concurrent auctions (#1593) * Adding timestamp function to utils * Auction manager (WIP) * WIP * Updated targeting with auction instances and added auction status * Updated appnexus and appnexusAst adapter * Added done callback * Removing bidmanager functions * Removing deprecated public api functions * remove bidmanager file * Revert "remove bidmanager file" This reverts commit 616409e. * Updated appnexus and rubicon adapters to call done callback after all responses are back * Added todo * Fixing circular dependency * filter s2s requests * Emit auction end Add getBidsRequested function * remove unused stuff from adapters * cleanup and fixes * Unit test fixes Added exclude to karma temporarily to support unit tests * added setTimeout for each auction instance * added constants closer to code * binded auction object inside done method * Adding auctionmanager_spec tests and fixes * Remove breakpoint * Moving auction to separate file and unit tests * Merged manually * Merged config api changes * Passing adunits, adunitscodes via constructor and fixing unit tests * added ajax with timeout * convert targeting module to factory pattern * Auction code refactored and unit tests * Updated bidderfactory for 1.0 changes and added unit tests * Renamed placementCode to adUnitCode * Refactor auction and update unit tests * JSDoc for auction and auctionManager * Unit test fixes after rebase * Manual merge new updates to bidmanager and its spec file into auction * Update appnexusAst spec file * Refactor * Prebid 1.0 does not require no_bid to be added * removed side effect by cloning objects * bug fix to set status on already used bid * Removing all !1.0 complaiant adapters * Adding aliases to appnexusAst adapter * Removed bidmanager from currency * Add ignore-loader to handle .md files (#1646) * Auction module refactor (#1644) * Auction moduel refactor * remove comment and global cbtimeout * Config api updates (#1633) * Add timeoutBuffer, s2sconfig, bidderSequence to config * Removing deprecated function and its unit test * fixed linting errors * Adapter/rubicon bid adapter markup (#1674) * initial take on rubiconBidAdapter markup * formatting * formatting, cont. * formatting, cont. * Prebid 1.0 Fix issue with video bid validation (#1680) * Fix issue with video bid validation * Modified tests to stub `auctionManager.getBidsRequested` instead of `getBidRequest` * Move stub to beforeEach hook * Fix lint errors * Add bidRequests param to bid validation * Auction module updated to support currency/hook (#1733) * added hook module to prebid core that allows extension of arbitrary functions * remove unused dependency tiny-queue * change PluginFunction to HookedFunction * more hook documentation fixes * Auction module updated to support currency/hook * remove unused dependency tiny-queue * change PluginFunction to HookedFunction * more hook documentation fixes * WIP * allow context for hooked functions * added tests for context * remove withContext, just use bind * fix in hooks so asyncSeries keeps proper bound context * Unit test fixes * Updated bid validation function * Fixed video unit test * updated sizeMapping to use sizeConfig and support labels (#1772) * updated sizeMapping to use sizeConfig and support labels * added new tests for labels and sizes w/ sizeConfig when making auction * made some names clearer and added type to labels for sizeMapping * make error message more descriptive in adaptermanager * remove extra line in adpatermanager * update package.json with correct version. (#1813) * Unit test fixes for IE 10 and other old browsers (#1810) * Added fix for location.origin * Fixed test case failing in IE and Safari browsers * Added utils.getOrigin method * Updated renderer to use hooks * Rename appnexusAst adapter to appnexus adapter (#1848) * Renamed appnexusAst adapter to appnexus * Updated unit test to use appnexus bidderCode * Remove completed todo comment * fixed safeframe for 1.0 (#1834) * Emit array of objects from BID_TIMEOUT event (#1824) * Emit array of objects from BID_TIMEOUT event * requestId is now auctionId * Use v4 UUID to match previous requestId format * Move function * Move public winningBids to auction (#1828) * Move public winningBids to auction * removed _winningBids * removed _winningBids * bugfix: return only new bids * Updates for PubWise Prebid 1.0 Support (#1847) * Updates for Prebid 1.0 Support * Updates for Bug Fixes and a small refactor * update JSDoc comment. Remove trailing space (#1872) tests were failing due to no trailing space eslint rule. * Prebid 1.0 adxcg analytics adapter fix for bidtimeout event (#1871) * adxcg analytics adapter for 1.0 bidtimeout event * update tests for adxcg analytics 1.0 * Prebid 1.0 prebid server (#1846) * fix adaptermanager s2sTest unit tests * fix s2s log message * remove errant comment * fixed log statement * removed seemingly unnecessary call to transformHeightWidth(adUnit); * removed legacy sizeMapping code block * initial refactor of prebidServerBidAdapter working w/o tests (cherry picked from commit 2b843d0) * add transformSizes back for prebidServer adUnits to fix request * fixed adapterManager_spec tests * added prebidServerBidAdapter tests for 1.0 * fixed lint errors * make sure addBidResponse and doneCb are stubbed for s2s calls * s2s requests now firing BID_REQUESTED event * fixed commented tests and other minor fixes * update defaults in prebidServerBidAdapter and fix doBidderSync bug * add new API for setting defaults in config for modules * Targeting updates (#1689) * Cherry pick alias bidder * Cherry pick alias bidder * Cherry pick alias bidder * Updated test case to not import adapter * targeting updates * targeting functions refactoring * Refactored functions * more refactor of function * added jsdoc and some more refactor * check bid expiry and filtering used bids * make sure we have the right version * Update version to fix invalid semver * video bug fix (#1906) * video bug fix added required params to prebidServerAdapter * Emitted auction_end and updated ttl for prebidServer * fix logging of server adapters * Manually merge bidManager code to auction module (#1905) * Unit test fix in IE for adxcgAnalytics Adapter (#1929) * IE bug fix * get only unique bidders * added log message for xhr timeout (#1928) * remove polyfill.js and remove global polyfills (#1918) * remove polyfill.js and remove global polyfills * make sure find, findIndex, and includes use core-js in tests * switch from virtual function bind core-js to explicit usage. * remove transform-function-bind babel plugin * Replace usePrebidCache with cache:url and remove default (#1904) * replace usePrebidCache with video:cacheUrl and remove default * remove newConfig in dfpAdServerVideo_spec that isn't doing anything * change video.cacheUrl to cache.url * update to cache.url in auction and remove from adapter * pulsepointLiteBidAdapter renamed to pulsepointBidAdapter (#1931) * ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per #509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing #866 * Minor fix * Adding mandatory parameters to Bid * Pulsepoint adapter changes * readme updates * add 'x_source.tid' to rubicon requests (#1933) * Bring in pre-1.0 native-image asset adapter change (#1934) * 33Across Adapter: Removed the usage of utils library (#1917) * Removed the usage of utils library to get bidder requests during userSync since this info will now be passed into the method * Fixed extra space which cause lint to fail * Implemented user sync per code review feedback in #1917 * Minor feedback changes * Re-instated lint check for all files which was accidentally commited after testing * Prebid 1.0 server cache (#1935) * add cache stuff to video for prebid server * add description for cacheMarkup

Eric Harper and others added 13 commits November 13, 2017 15:57

fix adaptermanager s2sTest unit tests

04e41b5

fix s2s log message

19ee680

remove errant comment

7ff136f

Merge branch 'prebid-1.0' into bugfix/s2sTesting-1.0

39ab810

fixed log statement

a2e2db6

removed seemingly unnecessary call to transformHeightWidth(adUnit);

432f466

removed legacy sizeMapping code block

dcc83e5

initial refactor of prebidServerBidAdapter working w/o tests

5be999e

(cherry picked from commit 2b843d0)

add transformSizes back for prebidServer adUnits to fix request

e35c0a8

fixed adapterManager_spec tests

b6ecc50

added prebidServerBidAdapter tests for 1.0

d0c0fd0

fixed lint errors

6274573

make sure addBidResponse and doneCb are stubbed for s2s calls

aba436e

mkendall07 assigned mkendall07 and jaiminpanchal27 Nov 17, 2017

snapwich mentioned this pull request Nov 17, 2017

s2sTesting module unit test fails in Prebid 1.0 #1723

Closed

jaiminpanchal27 added the Prebid 1.0 label Nov 20, 2017

mkendall07 reviewed Nov 21, 2017

View reviewed changes

mkendall07 approved these changes Nov 21, 2017

View reviewed changes

jaiminpanchal27 requested changes Nov 21, 2017

View reviewed changes

Eric Harper and others added 2 commits November 22, 2017 00:38

s2s requests now firing BID_REQUESTED event

a8c6cbf

Merge pull request #11 from rubicon-project/prebid-1.0-prebidServer-B…

35dcf5c

…ID_REQUEST-event s2s requests now firing BID_REQUESTED event

harpere reviewed Nov 22, 2017

View reviewed changes

fixed commented tests and other minor fixes

9e6ddc6

update defaults in prebidServerBidAdapter and fix doBidderSync bug

a579816

add new API for setting defaults in config for modules

09089fe

Merge branch 'prebid-1.0' into prebid-1.0-prebidServer

e3e4ee0

jaiminpanchal27 approved these changes Nov 28, 2017

View reviewed changes

mkendall07 approved these changes Nov 28, 2017

View reviewed changes

mkendall07 merged commit bbc2df0 into prebid:prebid-1.0 Nov 28, 2017

robertrmartinez deleted the prebid-1.0-prebidServer branch July 5, 2023 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prebid 1.0 prebid server #1846

Prebid 1.0 prebid server #1846

snapwich commented Nov 16, 2017

mkendall07 Nov 20, 2017

harpere Nov 22, 2017

mkendall07 Nov 21, 2017

mkendall07 Nov 21, 2017

mkendall07 Nov 21, 2017

mkendall07 commented Nov 21, 2017

jaiminpanchal27 left a comment

jaiminpanchal27 Nov 21, 2017

harpere Nov 22, 2017

jaiminpanchal27 Nov 21, 2017

harpere Nov 22, 2017

harpere Nov 22, 2017

mkendall07 Nov 22, 2017

snapwich Nov 27, 2017

mkendall07 Nov 27, 2017

jaiminpanchal27 Nov 21, 2017

mkendall07 Nov 27, 2017

snapwich Nov 27, 2017

harpere Nov 22, 2017

mkendall07 Nov 22, 2017

snapwich Nov 27, 2017

harpere commented Nov 22, 2017

snapwich commented Nov 27, 2017

snapwich commented Nov 28, 2017

Prebid 1.0 prebid server #1846

Prebid 1.0 prebid server #1846

Conversation

snapwich commented Nov 16, 2017

Type of change

Description of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkendall07 commented Nov 21, 2017

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harpere commented Nov 22, 2017

snapwich commented Nov 27, 2017

snapwich commented Nov 28, 2017