Create undertone udapter #1850

gilpat · 2017-11-19T15:18:58Z

Type of change

[*] New bidder adapter

Description of change

new undertone bidder adapter.

test parameters for validating bids

{
   bidder: 'undertone',
          params: {
            placementId: '10433394',
            publisherId: 12345
          }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer -RampProgrammatic@perion.com
official adapter submission

Other information

and adapter fixes

…t-udapter

# remove console.log in adapter

and relevant unit tests

change request that will be sent wait for different field in response update unit tests

gilpat · 2017-11-20T12:07:06Z

I saw that this error raised while running 'gulp run-tests'

HeadlessChrome 0.0.0 (Linux 0.0.0) MarsMedia adapter implementation "before each" hook FAILED
Error: Uncaught SyntaxError: Unexpected token < (http://localhost:9876/context.html:1)
HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 859 of 1622 (1 FAILED) (0 secs / 1.241 secs)
HeadlessChrome 0.0.0 (Linux 0.0.0) MarsMedia adapter implementation "before each" hook FAILED
Error: Uncaught SyntaxError: Unexpected token < (http://localhost:9876/context.html:1)
e 0.0.0 (Linux 0.0.0): Executed 859 of 1622 (1 FAILED) (28.686 secs / 1.241 secs)
[15:25:28] 'test-coverage' errored after 3.58 min
[15:25:28] Error: Karma tests failed with exit code 1
at /home/travis/build/prebid/Prebid.js/gulpfile.js:119:12
at removeAllListeners (/home/travis/build/prebid/Prebid.js/node_modules/karma/lib/server.js:380:7)
at Server. (/home/travis/build/prebid/Prebid.js/node_modules/karma/lib/server.js:391:9)
at Server.g (events.js:291:16)
at emitNone (events.js:91:20)
at Server.emit (events.js:185:7)
at emitCloseNT (net.js:1544:8)
at _combinedTickCallback (internal/process/next_tick.js:71:11)
at process._tickCallback (internal/process/next_tick.js:98:9)

I'm not getting this error locally , moreover, our pull request contains undertone adapter only , nothing that is related to Marsmedia .

can you please help?

mkendall07 · 2017-11-20T15:46:24Z

@gilpat We have some flakky tests. I've restarted the job to see if it passes

gilpat · 2017-11-20T16:31:28Z

Thanks ,
however the test raises now an error regards to indexExchange adapter

gilpat · 2017-11-21T13:09:38Z

Hi ,
is there anything we can do ? tests seem to fail for no reason I can see .

mkendall07 · 2017-11-22T18:19:43Z

@gilpat it's passing now

danagutkind · 2017-11-27T10:08:54Z

Hello Matt,
We would like to go live with prebid adaptor before Dec holidays.
Is there something that can be done to push forward the approval process of our adapter?
How many days it usually takes?
We appreciate any help from your side.
Thank you in advance.

jsnellbaker

@gilpat Thanks for submitting these changes. There are a few things that should be reviewed/updated, but mostly it seems good.

Please take a look at the specifics below and let me know if there are any questions. Thanks!

jsnellbaker · 2017-11-28T16:45:34Z

modules/undertoneBidAdapter.js

+    };
+  },
+  interpretResponse: function(serverResponse, request) {
+    const bids = [];


#1748 changed the first argument of interpretResponse to:

{ body: responseBody, headers: { get: function(header) { /* returns a header from the HTTP response */ } } }

so adding something like

serverResponse = serverResponse.body;

just below this line, or however you'd prefer to grab the body, and updating corresponding tests if needed should get this back to working properly

jsnellbaker · 2017-11-28T16:45:52Z

modules/undertoneBidAdapter.js

+        if (bidRes.ad && bidRes.cpm > 0) {
+          const bid = {
+            requestId: bidRes.bidRequestId,
+            bidderCode: BIDDER_CODE,


bidderCode will be set by bidderFactory automatically now, this line can be dropped

jsnellbaker · 2017-11-28T17:02:31Z

modules/undertoneBidAdapter.js

+    const payload = {
+      'x-ut-hb-params': []
+    };
+    const timeout = window.PREBID_TIMEOUT || null;


Can you clarify why the timeout value is needed for the bid object passed to your system? Is this a reporting metric or actively used by the system?

Prebid data can't be accessed directly through the window object. So we want to understand the need to help figure out some alternatives around supplying this information (if it's really needed).

Our API enable us to pass the timeout value to the server, so we can response with nobid if we are not able to respond within this time frame. This should improve the user experience and reduce load from our server.
Is there another way to get the timeout you're using? Or maybe there is a constant value you're using? If so, we can just add it here.

mkendall07 · 2017-11-28T20:05:32Z

@danagutkind
if you can get updates on this in the next 30 minutes we can include in the next release.

danagutkind · 2017-11-28T20:26:49Z

@mkendall07
Thank you very much for your comments.
We try to make it on time although 30 minutes is a challenge (our guys are at home at this hour).
When is your next release?

update after code review

mkendall07 · 2017-11-28T20:37:00Z

Ok np. Just wanted to give you the heads up. Possibly next week depending on things shake out.

danagutkind · 2017-11-28T20:43:24Z

@mkendall07
Hi Matt,
Furtunatelly, we managed to push all comments from your side.
We will be grateful if you include out adapter in the closest release.
Thank you for your help and responsiveness. We appreciate it.

mkendall07 · 2017-11-28T21:06:04Z

modules/undertoneBidAdapter.js

+import { registerBidder } from 'src/adapters/bidderFactory';
+
+const BIDDER_CODE = 'undertone';
+const URL = '//hb.undertone.com/hb'; // //ads.undertone.com/hb


What's //ads.undertone.com/hb ? Could remove this comment

mkendall07 · 2017-11-28T21:45:04Z

@gilpat We are seeing a CORS related error when testing the adapter. Are you sure the test params are valid and work on the hello world test page?

jsnellbaker · 2017-11-29T15:25:29Z

After retesting this morning, we're able to see the test ad with the hello word test page.

LGTM

danagutkind · 2017-12-04T09:55:52Z

@mkendall07
Hello Matt,
Would you please tell when is our adapter expected to go live?
We would like to update our publisher.
Many thanks again,
Dana

danagutkind · 2017-12-07T12:11:17Z

@mkendall07 Hi Matt
Do you have any estimation when our adapter goes live?
I am asking as we are committed to our publishers.
We would like to reflect timelines as best as we can, so it will be helpful for us to know.
Can you please advice?

Thank you,
Dana

mkendall07 · 2017-12-07T13:50:22Z

What do you mean live? This is merged and available in the 0.34 release I believe

danagutkind · 2017-12-07T15:26:19Z

@mkendall07

Thank you very much.
I see our adapter is merged and available.

* create adapter * start ut unit tests * add unit tests and adapter fixes * add interpretResponse unit tests * update interpretResponse * add unit tests # remove console.log in adapter * add timeout * fix unit test * update request and relevant unit tests * request and response change request that will be sent wait for different field in response update unit tests * update * prebid- undertone adapter * update update after code review * fix spec after code review changes * remove comment

AnnaPerion and others added 13 commits October 22, 2017 09:20

create adapter

02f6569

start ut unit tests

0102ca1

add unit tests

b4ca9fd

and adapter fixes

add interpretResponse unit tests

bdbd153

update interpretResponse

00b84ed

Merge remote-tracking branch 'origin/create-ut-udapter' into create-u…

b66f3dc

…t-udapter

add unit tests

1077e68

# remove console.log in adapter

add timeout

10d4e92

fix unit test

2b4e23f

update request

1eae245

and relevant unit tests

request and response

9de1d5a

change request that will be sent wait for different field in response update unit tests

update

7d1e224

prebid- undertone adapter

e79b30d

bretg requested a review from pm-harshad-mane November 20, 2017 16:56

bretg added the needs review label Nov 20, 2017

bretg assigned pm-harshad-mane Nov 20, 2017

bretg removed the request for review from pm-harshad-mane November 20, 2017 20:54

mkendall07 requested a review from jsnellbaker November 28, 2017 15:05

mkendall07 assigned jsnellbaker Nov 28, 2017

jsnellbaker requested changes Nov 28, 2017

View reviewed changes

jsnellbaker added needs update and removed needs review labels Nov 28, 2017

update

f9ff6c1

update after code review

fix spec after code review changes

01ccb13

mkendall07 reviewed Nov 28, 2017

View reviewed changes

mkendall07 approved these changes Nov 28, 2017

View reviewed changes

remove comment

faa122f

bretg mentioned this pull request Nov 29, 2017

undertone bid adapter prebid/prebid.github.io#453

Merged

jsnellbaker approved these changes Nov 29, 2017

View reviewed changes

jsnellbaker merged commit ff9cd38 into prebid:master Nov 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create undertone udapter #1850

Create undertone udapter #1850

gilpat commented Nov 19, 2017

gilpat commented Nov 20, 2017

mkendall07 commented Nov 20, 2017

gilpat commented Nov 20, 2017

gilpat commented Nov 21, 2017

mkendall07 commented Nov 22, 2017

danagutkind commented Nov 27, 2017

jsnellbaker left a comment

jsnellbaker Nov 28, 2017

jsnellbaker Nov 28, 2017

jsnellbaker Nov 28, 2017 •

edited

Loading

shaymandel Nov 28, 2017

mkendall07 commented Nov 28, 2017

danagutkind commented Nov 28, 2017

mkendall07 commented Nov 28, 2017

danagutkind commented Nov 28, 2017

mkendall07 Nov 28, 2017

mkendall07 commented Nov 28, 2017

jsnellbaker commented Nov 29, 2017

danagutkind commented Dec 4, 2017

danagutkind commented Dec 7, 2017

mkendall07 commented Dec 7, 2017

danagutkind commented Dec 7, 2017

Create undertone udapter #1850

Create undertone udapter #1850

Conversation

gilpat commented Nov 19, 2017

Type of change

Description of change

Other information

gilpat commented Nov 20, 2017

mkendall07 commented Nov 20, 2017

gilpat commented Nov 20, 2017

gilpat commented Nov 21, 2017

mkendall07 commented Nov 22, 2017

danagutkind commented Nov 27, 2017

jsnellbaker left a comment

Choose a reason for hiding this comment

jsnellbaker Nov 28, 2017

Choose a reason for hiding this comment

jsnellbaker Nov 28, 2017

Choose a reason for hiding this comment

jsnellbaker Nov 28, 2017 • edited Loading

Choose a reason for hiding this comment

shaymandel Nov 28, 2017

Choose a reason for hiding this comment

mkendall07 commented Nov 28, 2017

danagutkind commented Nov 28, 2017

mkendall07 commented Nov 28, 2017

danagutkind commented Nov 28, 2017

mkendall07 Nov 28, 2017

Choose a reason for hiding this comment

mkendall07 commented Nov 28, 2017

jsnellbaker commented Nov 29, 2017

danagutkind commented Dec 4, 2017

danagutkind commented Dec 7, 2017

mkendall07 commented Dec 7, 2017

danagutkind commented Dec 7, 2017

jsnellbaker Nov 28, 2017 •

edited

Loading