Justpremium Adapter for 1.0 #1881

mkalafior · 2017-11-23T15:00:49Z

Type of change

Description of change

test parameters for validating bids

       {
           sizes: [[1, 1]],
           code: 'div-gpt-ad-1471513102552-0',
           bids: [
               {
                   bidder: 'justpremium', 
                   params: {
                       zone: 34364
                   }
               },
           ]
       }

maintainer: sebastian.widelak@justpremium.com
official adapter submission

@matthewlane @ndhimehta @snapwich I created new pr as after merging latest master to branch used in previous one some files were just deleted causing that tests failed. This one contains exactly the same code, so we will be very grateful for quick approval.

matthewlane

Thanks for opening the PR against master. A few changes requested

matthewlane · 2017-11-24T19:09:36Z

modules/justpremiumBidAdapter.js

+import { registerBidder } from 'src/adapters/bidderFactory'
+
+const BIDDER_CODE = 'justpremium'
+const ENDPOINT_URL = top.document.location.protocol + '//pre.ads.justpremium.com/v/2.0/t/xhr'


top should generally be in a try/catch block, or use utils.getTopWindowLocation() to safely get location here

matthewlane · 2017-11-24T19:11:02Z

modules/justpremiumBidAdapter.js

+ return parseInt(b.params.zone)
+ }))].join(','),
+ hostname: top.document.location.hostname,
+ protocol: top.document.location.protocol.replace(':', ''),


Can also use utils.getTopWindowLocation() in the above two lines

matthewlane · 2017-11-24T19:14:36Z

modules/justpremiumBidAdapter.js

+ sw: window.top.screen.width,
+ sh: window.top.screen.height,
+ ww: window.top.innerWidth,
+ wh: window.top.innerHeight,


The above four window.top references will need to be in a try/catch block, or can set up a variable that access window.top, place that within a try/catch, and access it here

matthewlane · 2017-11-24T19:19:36Z

test/spec/modules/justpremiumBidAdapter_spec.js

- }
- document.cookie = name + '=' + value + expires + '; path=/';
-}
+import { expect, assert } from 'chai'


assert isn't used, can be removed from import

matthewlane · 2017-11-24T19:19:56Z

test/spec/modules/justpremiumBidAdapter_spec.js

+import { expect, assert } from 'chai'
+import { spec } from 'modules/justpremiumBidAdapter'
+import { getTopWindowLocation } from 'src/utils'
+import { newBidder } from 'src/adapters/bidderFactory'


The above two imports aren't used in the test, can be removed

matthewlane · 2017-11-24T19:21:20Z

modules/justpremiumBidAdapter.js

+ }
+ },
+
+ interpretResponse: (serverResponse, bidRequests) => {


#1748 changed the first argument of interpretResponse to:

{ body: responseBody, headers: { get: function(header) { /* returns a header from the HTTP response */ } } }

so adding something like

serverResponse = serverResponse.body;

just below this line, or however you'd prefer to grab the body, and updating corresponding tests if needed should get this back to working properly

matthewlane · 2017-11-24T19:24:39Z

modules/justpremiumBidAdapter.js

+ let size = (adUnit.sizes && adUnit.sizes.length && adUnit.sizes[0]) || []
+ let bidResponse = {
+ requestId: bidId,
+ bidderCode: spec.code,


bidderCode will be set by bidderFactory automatically now, this line can be dropped

matthewlane · 2017-11-24T19:33:41Z

modules/justpremiumBidAdapter.js

+ ad: bid.adm,
+ cpm: bid.price,
+ currency: bid.currency || 'USD',
+ ttl: bid.ttl || spec.time


netRevenue and creativeId will also need to be in this object to pass validation, see the table in http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for a description of these fields

mkalafior · 2017-11-25T09:15:53Z

@matthewlane all requested changes were applied.

jsnellbaker

with the most recent changes, LGTM

* Justpremium adapter and unit tests. * Fix test suit. * Performance improvements. * Changes requested in pull request review. * Register justpremium adapter in adaptermanager * pass through bid from request * fix linting errors * Load polyfills for older browsers * Load polyfills if older browser * Remove package-lock.json * Copy new Justpremium adapter from feature/1.0 branch * #1881 Requested changes applied * #1892 Use `filter` instead `...new Set` to get unique values

* Justpremium adapter and unit tests. * Fix test suit. * Performance improvements. * Changes requested in pull request review. * Register justpremium adapter in adaptermanager * pass through bid from request * fix linting errors * Load polyfills for older browsers * Load polyfills if older browser * Remove package-lock.json * Copy new Justpremium adapter from feature/1.0 branch * #1881 Requested changes applied * #1892 Use `filter` instead `...new Set` to get unique values * JSD-2248 update for adapter and tests * JSD-2248 added transactionId in json array * JSD-2248 adapter changes * JSD-2248 adapter changes * Update docs * Remove unnecessary return statement * Support for gdpr_consent in bid adapter * new cookie link and endpoint * back to old endpoint version * sending version of prebid and adapter * sending version of prebid and adapter * without version * update for tests * changes for getUserSyncs method * return gulpfile changes

* Justpremium adapter and unit tests. * Fix test suit. * Performance improvements. * Changes requested in pull request review. * Register justpremium adapter in adaptermanager * pass through bid from request * fix linting errors * Load polyfills for older browsers * Load polyfills if older browser * Remove package-lock.json * Copy new Justpremium adapter from feature/1.0 branch * prebid#1881 Requested changes applied

* Justpremium adapter and unit tests. * Fix test suit. * Performance improvements. * Changes requested in pull request review. * Register justpremium adapter in adaptermanager * pass through bid from request * fix linting errors * Load polyfills for older browsers * Load polyfills if older browser * Remove package-lock.json * Copy new Justpremium adapter from feature/1.0 branch * prebid#1881 Requested changes applied * prebid#1892 Use `filter` instead `...new Set` to get unique values

* Justpremium adapter and unit tests. * Fix test suit. * Performance improvements. * Changes requested in pull request review. * Register justpremium adapter in adaptermanager * pass through bid from request * fix linting errors * Load polyfills for older browsers * Load polyfills if older browser * Remove package-lock.json * Copy new Justpremium adapter from feature/1.0 branch * prebid#1881 Requested changes applied * prebid#1892 Use `filter` instead `...new Set` to get unique values * JSD-2248 update for adapter and tests * JSD-2248 added transactionId in json array * JSD-2248 adapter changes * JSD-2248 adapter changes * Update docs * Remove unnecessary return statement * Support for gdpr_consent in bid adapter * new cookie link and endpoint * back to old endpoint version * sending version of prebid and adapter * sending version of prebid and adapter * without version * update for tests * changes for getUserSyncs method * return gulpfile changes

mkalafior added 19 commits May 24, 2017 14:26

Justpremium adapter and unit tests.

8aa8f9c

Fix test suit.

00a2ce6

Performance improvements.

0816e98

Changes requested in pull request review.

6cc1617

Merge with upstream

4917b85

Register justpremium adapter in adaptermanager

5fefb28

Merge remote-tracking branch 'upstream/master'

92da906

Merge branch 'master' of https://github.com/prebid/Prebid.js

83d5022

pass through bid from request

16a7b42

Merge branch 'master' of https://github.com/prebid/Prebid.js

b943b79

fix linting errors

d8ddfd0

merge

62438ed

Load polyfills for older browsers

d8e5cf8

Merge remote-tracking branch 'upstream/master'

1eb433a

Merge branch 'master' into bugfix/ie-polyfills

97b0dd7

Load polyfills if older browser

4683a30

Remove package-lock.json

ed9979e

Merge remote-tracking branch 'upstream/master'

34ea947

Copy new Justpremium adapter from feature/1.0 branch

e28bc0f

mkalafior mentioned this pull request Nov 23, 2017

Justpremium Adapter for 1.0 #1782

Closed

9 tasks

matthewlane self-assigned this Nov 24, 2017

matthewlane self-requested a review November 24, 2017 19:29

matthewlane requested changes Nov 24, 2017

View reviewed changes

matthewlane reviewed Nov 24, 2017

View reviewed changes

matthewlane added the needs update label Nov 24, 2017

prebid#1881 Requested changes applied

16047de

mkendall07 requested a review from jsnellbaker November 27, 2017 17:51

mkendall07 assigned jsnellbaker Nov 27, 2017

jsnellbaker approved these changes Nov 27, 2017

View reviewed changes

matthewlane approved these changes Nov 28, 2017

View reviewed changes

matthewlane added LGTM and removed needs update labels Nov 28, 2017

matthewlane merged commit 02d2d4c into prebid:master Nov 28, 2017

jsnellbaker mentioned this pull request Nov 28, 2017

Unable to use spread operator/Set object #1892

Closed

mkalafior mentioned this pull request Nov 29, 2017

Justpremium Adapter: use filter instead of ...new Set #1895

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Justpremium Adapter for 1.0 #1881

Justpremium Adapter for 1.0 #1881

mkalafior commented Nov 23, 2017

matthewlane left a comment

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

matthewlane Nov 24, 2017

mkalafior commented Nov 25, 2017

jsnellbaker left a comment

Justpremium Adapter for 1.0 #1881

Justpremium Adapter for 1.0 #1881

Conversation

mkalafior commented Nov 23, 2017

Type of change

Description of change

matthewlane left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkalafior commented Nov 25, 2017

jsnellbaker left a comment

Choose a reason for hiding this comment