Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trion Interactive Adapter Bugfix #1925

Merged
merged 9 commits into from
Dec 6, 2017
Merged

Trion Interactive Adapter Bugfix #1925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21bab6b
Adding files associated with the trion adapter update to the newest p…
Oct 17, 2017
fae1208
Merge branch 'master' into master
grohm33 Oct 17, 2017
3abcf64
Updating pull request with safer checks for user sync and general cle…
Oct 18, 2017
0c040fc
removing a call to bidder code for pull request review. also removin…
Nov 13, 2017
40444f7
Merge remote-tracking branch 'upstream/master'
Nov 13, 2017
324d157
there were some changes to the bid factory after our initial release …
Dec 5, 2017
bb5f8c7
Revert "there were some changes to the bid factory after our initial …
Dec 5, 2017
8d40681
Merge remote-tracking branch 'upstream/master'
Dec 5, 2017
8d67f63
there were some changes to the bid factory after our initial release …
Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/trionBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ export const spec = {
var bid = {};
var bidResponses = [];
var bidRequest = request.bidRequest;
var responseBody = trionResponseObj ? trionResponseObj.body : {};

if (trionResponseObj && trionResponseObj.bidId && bidRequest) {
var result = trionResponseObj.result;
if (responseBody && responseBody.bidId && bidRequest) {
var result = responseBody.result;

if (result && result.cpm && result.placeBid && result.ad) {
var cpm = parseInt(result.cpm, 10) / 100;
Expand All @@ -45,6 +46,10 @@ export const spec = {
bid.ad = result.ad;
bid.width = result.width;
bid.height = result.height;
bid.ttl = result.ttl;
bid.creativeId = result.creativeId;
bid.currency = result.currency;
bid.netRevenue = result.netRevenue;
bidResponses.push(bid);
}
}
Expand Down
10 changes: 5 additions & 5 deletions test/spec/modules/trionBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ describe('Trion adapter tests', () => {

it('when place bid is returned as false', () => {
TRION_BID_RESPONSE.result.placeBid = false;
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});

expect(response).to.deep.equal([]);

Expand All @@ -136,14 +136,14 @@ describe('Trion adapter tests', () => {

it('when no cpm is in the response', () => {
TRION_BID_RESPONSE.result.cpm = 0;
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
expect(response).to.deep.equal([]);
TRION_BID_RESPONSE.result.cpm = 1;
});

it('when no ad is in the response', () => {
TRION_BID_RESPONSE.result.ad = null;
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
expect(response).to.deep.equal([]);
TRION_BID_RESPONSE.result.ad = 'test';
});
Expand All @@ -153,7 +153,7 @@ describe('Trion adapter tests', () => {
let bidHeight = '2';
TRION_BID_RESPONSE.result.width = bidWidth;
TRION_BID_RESPONSE.result.height = bidHeight;
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
expect(response[0].width).to.equal(bidWidth);
expect(response[0].height).to.equal(bidHeight);
TRION_BID_RESPONSE.result.width = '300';
Expand All @@ -163,7 +163,7 @@ describe('Trion adapter tests', () => {
it('cpm is properly set and transformed to cents', () => {
let bidCpm = 2;
TRION_BID_RESPONSE.result.cpm = bidCpm * 100;
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
expect(response[0].cpm).to.equal(bidCpm);
TRION_BID_RESPONSE.result.cpm = 100;
});
Expand Down