Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsepointLiteBidAdapter renamed to pulsepointBidAdapter #1931

Merged
merged 22 commits into from
Dec 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2fba6a2
ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)
anand-venkatraman Oct 14, 2016
ca17acb
Merge remote-tracking branch 'upstream/master'
anand-venkatraman Oct 25, 2016
5da43c3
Adding bidRequest to bidFactory.createBid method as per https://githu…
anand-venkatraman Oct 25, 2016
cf41114
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Nov 8, 2016
62756a9
ET-1765: Adding support for additional params in PulsePoint adapter (#2)
anand-venkatraman Nov 9, 2016
f8fabb7
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Dec 8, 2016
b9af15c
ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866
anand-venkatraman Dec 8, 2016
6523c25
Merge pull request #3 from pulsepointinc/ET-1850
anand-venkatraman Dec 8, 2016
b5eeb7f
Minor fix
anand-venkatraman Dec 8, 2016
0f33ef5
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Mar 1, 2017
b5dbd34
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Jun 27, 2017
d6fcd11
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Jul 17, 2017
fce16ad
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Aug 15, 2017
9833867
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Sep 22, 2017
70924c5
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Oct 12, 2017
41f4aca
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman Nov 13, 2017
aae98a7
Adding mandatory parameters to Bid
anand-venkatraman Nov 13, 2017
6d546ed
Merge from upstream
anand-venkatraman Nov 27, 2017
6fd8262
Merge from remote
anand-venkatraman Nov 27, 2017
86c849f
Merge branch 'prebid-1.0' of https://github.com/prebid/Prebid.js into…
anand-venkatraman Dec 6, 2017
3a59727
Pulsepoint adapter changes
anand-venkatraman Dec 6, 2017
96be959
readme updates
anand-venkatraman Dec 6, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,18 @@ const DEFAULT_CURRENCY = 'USD';
const DEFAULT_NET_REVENUE = true;

/**
* PulsePoint "Lite" Adapter. This adapter implementation is lighter than the
* alternative/original PulsePointAdapter because it has no external
* dependencies and relies on a single OpenRTB request to the PulsePoint
* bidder instead of separate requests per slot.
* PulsePoint Bid Adapter.
* Contact: ExchangeTeam@pulsepoint.com
*
* Aliases - pulseLite and pulsepointLite are supported for backwards compatibility.
* Formats - Display/Native/Outstream formats supported.
*
*/
export const spec = {

code: 'pulseLite',
code: 'pulsepoint',

aliases: ['pulsepointLite'],
aliases: ['pulseLite', 'pulsepointLite'],

supportedMediaTypes: ['native'],

Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
# Overview

**Module Name**: PulsePoint Lite Bidder Adapter
**Module Name**: PulsePoint Bidder Adapter
**Module Type**: Bidder Adapter
**Maintainer**: ExchangeTeam@pulsepoint.com

# Description

Connects to PulsePoint demand source to fetch bids.
Banner, Outstream and Native formats are supported.
Please use ```pulseLite``` as the bidder code.
Please use ```pulsepoint``` as the bidder code.
```pulseLite``` and ```pulsepointLite``` aliases also supported as well.

# Test Parameters
```
var adUnits = [{
code: 'banner-ad-div',
sizes: [[300, 250]],
bids: [{
bidder: 'pulsepointLite',
bidder: 'pulsepoint',
params: {
cf: '300X250',
cp: 512379,
Expand All @@ -33,7 +34,7 @@ Please use ```pulseLite``` as the bidder code.
sponsoredBy: { len: 20 }
},
bids: [{
bidder: 'pulseLite',
bidder: 'pulsepoint',
params: {
cp: 512379,
ct: 505642
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* eslint dot-notation:0, quote-props:0 */
import {expect} from 'chai';
import {spec} from 'modules/pulsepointLiteBidAdapter';
import {spec} from 'modules/pulsepointBidAdapter';
import {getTopWindowLocation} from 'src/utils';
import {newBidder} from 'src/adapters/bidderFactory';

describe('PulsePoint Lite Adapter Tests', () => {
describe('PulsePoint Adapter Tests', () => {
const slotConfigs = [{
placementCode: '/DfpAccount1/slot1',
bidId: 'bid12345',
Expand Down Expand Up @@ -218,12 +218,13 @@ describe('PulsePoint Lite Adapter Tests', () => {
});

it('Verifies bidder code', () => {
expect(spec.code).to.equal('pulseLite');
expect(spec.code).to.equal('pulsepoint');
});

it('Verifies bidder aliases', () => {
expect(spec.aliases).to.have.lengthOf(1);
expect(spec.aliases[0]).to.equal('pulsepointLite');
expect(spec.aliases).to.have.lengthOf(2);
expect(spec.aliases[0]).to.equal('pulseLite');
expect(spec.aliases[1]).to.equal('pulsepointLite');
});

it('Verifies supported media types', () => {
Expand Down