Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate request id and fix empty response from getHighesCpmBids, getAdserverTargeting #1970

Merged
merged 5 commits into from
Dec 19, 2017
Merged

Remove duplicate request id and fix empty response from getHighesCpmBids, getAdserverTargeting #1970

merged 5 commits into from
Dec 19, 2017

Commits on Dec 14, 2017

  1. Removed requestId and added auctionId

    @jaiminpanchal27
    jaiminpanchal27 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    cadbe0c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2017

  1. Updated module fixtures to use auctionId and not requestId

    @jaiminpanchal27
    jaiminpanchal27 committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    3204114 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. remove request id from external bid object and fix bug for empty resu… 

    …lt in public api
    @jaiminpanchal27
    jaiminpanchal27 committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    75de0e6 View commit details
    Browse the repository at this point in the history

  2. use auctionId instead of requestId

    @jaiminpanchal27
    jaiminpanchal27 committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    35ed418 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. fixed lint errors

    @jaiminpanchal27
    jaiminpanchal27 committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    622a872 View commit details
    Browse the repository at this point in the history