Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Bid Adapter for Dentsu Aegis Network Marketplace #1982

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Make Bid Adapter for Dentsu Aegis Network Marketplace #1982

merged 3 commits into from
Feb 1, 2018

Conversation

danmarketplace
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Bid Adapter for Dentsu Aegis Network Marketplace

  • test parameters for validating bids
{
  bidder: 'danmarketplace',
  params: {
    uid: 4,
    priceType: 'gross' // by default is 'net'
  }
}

snapwich
snapwich approved these changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich added the LGTM label Jan 17, 2018
matthewlane
matthewlane requested changes Jan 22, 2018
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one requested change. Please also submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page

modules/danmarketplaceBidAdapter.js Outdated
awaitingBids.forEach(bid => {
const bidResponse = {
requestId: bid.bidId, // bid.bidderRequestId,
bidderCode: spec.code,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bidderCode is set automatically by bidderFactory now, setting it here will break aliasing, line and corresponding test lines should be dropped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed it, please review.

@mkendall07 mkendall07 removed the request for review from pm-harshad-mane January 23, 2018 21:16
@mkendall07 mkendall07 added this to the Prebid 1.3 release milestone Jan 24, 2018
@matthewlane matthewlane assigned matthewlane and unassigned snapwich Jan 25, 2018
@matthewlane matthewlane merged commit 06e916f into prebid:master Feb 1, 2018
@matthewlane
Copy link
Collaborator

Docs PR: https://github.com/prebid/prebid.github.io/pull/585/files

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@danmarketplace @dluxemburg
Make Bid Adapter for Dentsu Aegis Network Marketplace (prebid#1982)
a1f5661 
* Make Bid Adapter for Dentsu Aegis Network Marketplace

* Update DAN_Marketplace adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@matthewlane matthewlane

Labels
LGTM
Projects
None yet
Milestone
Prebid 1.3 release
Development

Successfully merging this pull request may close these issues.
5 participants
@danmarketplace @matthewlane @snapwich @mkendall07 @pm-harshad-mane