Update ucfunnelBidAdapter #1990
Conversation
2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
|
You need to include tests (with 80%+ coverage) with your adapter for it to be merged. Also your pull-request description is just the template, you need to fill in the details. |
|
@snapwich we add the test case of ucfunnelBidAdapter for v1.0. |
| expect(request[0].url).to.equal(URL); | ||
| }); | ||
| it('bidRequest data', () => { | ||
| const request = spec.buildRequests(bidReq); |
There was a problem hiding this comment.
There's no reason this needs to be three separate tests. It will just make the test suite run longer for no discernible reason.
|
@snapwich We combine all tests for bid request into single one. |
|
Hello @snapwich We expect this commit can be merged into Prebid:master. And then ucfunnel adapter will be released and listed in the page http://prebid.org/download.html? |
* Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
support@ucfunnel.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information