Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native is reserved keyword, use bracket/quotes to reference property #2066

Merged

Conversation

kitwestneat
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Port of 6cf71d0 to 1.0. 'native' is a reserved keyword, and its use as a property breaks some tools. Use ['native'] to safely refer to it.

Other information

#1984

@jaiminpanchal27 jaiminpanchal27 self-requested a review January 25, 2018 14:18
@jaiminpanchal27 jaiminpanchal27 merged commit 548fce2 into prebid:master Jan 25, 2018
@jaiminpanchal27 jaiminpanchal27 added this to the Prebid 1.3 release milestone Jan 25, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants