Read secure fields to send requests

[AntoineJac]

On http page, a video request will then raise an error as the non secure creative will be called from the player which is an https iframe so raise an error.

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[bretg]

@AntoineJac - this PR might need to be rebased to pass CI. See #2042

[snapwich]

One small change. Also you have some linting errors that are failing the build. You can run the linter with the gulp lint command on the command line.

[snapwich]

should anchor this regex to beginning just in-case.

.replace(/^http:/

[AntoineJac]

Thanks Rich, Just update it, and pass CI Cheers, Antoine Jacquemin Senior Solution Engineer - International M: +65 86 719 728 | *Linkedin:* Antoine Jacquemin 137 AMOY STREET, #3-04A, FAR EAST SQUARE, SINGAPORE, 049965 RUBICONPROJECT.COM <http://www.rubiconproject.com> | JOIN US <http://rubiconproject.com/join-us/> | FOLLOW US <http://twitter.com/rubiconproject> <http://www.chango.com/about/careers/>

…

On Tue, Jan 30, 2018 at 2:28 AM, Rich Snapp ***@***.***> wrote: ***@***.**** requested changes on this pull request. One small change. Also you have some linting errors that are failing the build. You can run the linter with the gulp lint command on the command line. ------------------------------ In modules/rubiconBidAdapter.js <#2078 (comment)>: > let data = { - page_url: !params.referrer ? utils.getTopWindowUrl() : params.referrer, + page_url: bid.param.secure ? page_rf.replace(/http:/i, "https:") : page_rf, should anchor this regex to beginning just in-case. .replace(/^http:/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2078 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV9TzOQrV6BzHy_s1kjUwdINZc1seXzqks5tPg24gaJpZM4RwTM0> .

[snapwich]

LGTM