Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - interpretResponse #2082

Merged
merged 9 commits into from
Feb 2, 2018
Merged

Bugfix - interpretResponse #2082

merged 9 commits into from
Feb 2, 2018

Conversation

rade-popovic
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Bugfix interpretResponse - added body in serverResponse.
  • Removed unnecessary parameters (they are not used), they do not change user-facing API.
  • Adjusted tests accordingly.

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich added the LGTM label Jan 30, 2018
@bretg bretg removed the needs review label Feb 2, 2018
@snapwich snapwich merged commit 0b98a8c into prebid:master Feb 2, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* nanointeractive bid adapter
* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants