PR / Issue Review process update #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Feb 1, 2018
pr_review.md
Outdated
| We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-better-code-reviews-16109e0fdd36#.xa8lc4i23 to understand how a PR review should be conducted. Be rational and strict in your review, make sure you understand exactly what the submitter's intent is. Overall 1 person should take ownership of a particular PR. When they are satisfied it's in good condition to merge, they should request 1 additional team member to review as a sanity check. Only when the PR has 2 `LGTM` from the core team should it be merged. | ||
| We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-better-code-reviews-16109e0fdd36#.xa8lc4i23 to understand how a PR review should be conducted. Be rational and strict in your review, make sure you understand exactly what the submitter's intent is. Anyone in the community can review a PR, but a Prebid Org member is also required. A Prebid Org member should take ownership of a PR and do the initial review. | ||
|
|
||
| If the PR is for a standard bid adapter or a standard analytics adapter, just the one review is sufficient. The reviewer will check against [required conventions](http://prebid.org/dev-docs/bidder-adaptor.html#required-adapter-conventions) and may merge the PR after approving and confirming that the documentation PR against prebid.org is open and linked to the issue. |
There was a problem hiding this comment.
just the one review [from a core team member] is sufficient
pr_review.md
Outdated
| @@ -23,3 +27,20 @@ We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-b | |||
| - Verify that code re-use is being done properly and that changes introduced by a bidder don't impact other bidders. | |||
| - If the adapter being submitted is an alias type, check with the bidder contact that is being aliased to make sure it's allowed. | |||
| - If the adapter is triggering any user syncs make sure they are using the user sync module in the Prebid.js core. | |||
| - Requests to the bidder should be in HTTPS | |||
| - Responses from the bidder should be compressed | |||
There was a problem hiding this comment.
(such as gzip, compress, deflate)
pr_review.md
Outdated
| @@ -23,3 +27,20 @@ We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-b | |||
| - Verify that code re-use is being done properly and that changes introduced by a bidder don't impact other bidders. | |||
| - If the adapter being submitted is an alias type, check with the bidder contact that is being aliased to make sure it's allowed. | |||
| - If the adapter is triggering any user syncs make sure they are using the user sync module in the Prebid.js core. | |||
| - Requests to the bidder should be in HTTPS | |||
There was a problem hiding this comment.
should support HTTPS (doesn't have to be HTTPS 100% of the time)
matthewlane
reviewed
Feb 1, 2018
|
Not sure the best way to rename a file... copy and delete? @mkendall07 ? |
|
@bretg "git mv pr_review.md PR_REVIEW.md" will track the file change without Git losing its mind. |
mkendall07
approved these changes
Feb 2, 2018
|
@bretg |
matthewlane
approved these changes
Feb 6, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* PR / Issue Review process update * Update pr_review.md * Capitalize filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updated process documentation as discussed in the Prebid Org meeting today.