Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote.html is being deprecated in AMP. Pointer to the Prebid Server … #2110

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

hhhjort
Copy link
Contributor

@hhhjort hhhjort commented Feb 6, 2018

…solution added in addition to a deprecation warning

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updating AMP documentation to reflect remote.html being deprecated.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

…solution added in addition to a deprecation warning
@@ -1,3 +1,10 @@
##WARNING
The below documented method of deploying prebid on AMP requires remote.html
This is being deprecated on March 29th. A new method the requires Prebid Server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the year be added to the date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, especially for long term (someone reads this in 2019). Added.

@mkendall07 mkendall07 merged commit 0923c91 into prebid:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants