size mapping throws warning if mediaQuery missing #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snapwich Can you add a unit test. Code looks good. |
|
updated |
jaiminpanchal27
approved these changes
Feb 9, 2018
|
@snapwich please add a docs PR and we should be good to merge. Thanks! |
|
I'm not sure exactly which parts of the docs you want updated. I added "required" to the mediaQuery description, is that what you mean? |
|
@snapwich I think that would be fine. @jaiminpanchal27 did you have any other ideas as to documentation changes? |
|
No. As per our process we only need a docs PR open to merge any PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added warning if
mediaQueryis missing as discussed in issue #2043