Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded lint exceptions #2129

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Remove unneeded lint exceptions #2129

merged 1 commit into from
Feb 12, 2018

Conversation

matthewlane
Copy link
Collaborator

@matthewlane matthewlane commented Feb 8, 2018

Type of change

  • Maintenance

Description of change

Some of the lint exceptions aren't needed anymore and can be removed without touching any code. Running gulp lint with these removed should result in 0 errors.

Other information

Chipping away at #1206

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit ef4354b into master Feb 12, 2018
@matthewlane matthewlane deleted the remove-lint-exceptions branch February 12, 2018 18:32
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants