Update to sovrn custom params as well as site object construction #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send 'iv' param if present and full url in `site.page`
harpere
approved these changes
Feb 15, 2018
9 tasks
matthewlane
approved these changes
Feb 15, 2018
9 tasks
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…ebid#2149) * fix sovrn dealid * send 'iv' param if present * `page` field in `site` object sends full url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Sovrn internally uses a custom param called 'iv' to log ad refresh events, this change is to send the parameter through prebid auctions as well. Also included is a minor update in setting the page field of the site object of a bid request to align with the OpenRTB 2.5 spec.