Auctionmanager spec refactor pr #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consolidate duplicated code into helper functions.
mizmaar3
added a commit
to widespace-os/Prebid.js
that referenced
this pull request
Mar 8, 2018
* master: (27 commits) Increment pre version Prebid 1.5.0 Release Fix cross-platform test failures (prebid#2228) Fix uncahced video bids from multi-response array triggering callback early (prebid#2219) Add vuble adapter (prebid#2201) Update Vidazoo domain (prebid#2223) InSkin Bid Adapter: remove referrer field from request body (prebid#2217) Gamma Support UserSync Endpoint (prebid#2216) Feature/stale bot (prebid#2192) 33Across Bid Adapter: updated user sync endpoint (prebid#2193) Adding PR_REVIEW guideline (prebid#2159) Add FairTrade Bid Adapter (prebid#2147) Add banner support to Beachfront adapter (prebid#2117) Smartyads Adapter 1.x (prebid#2080) Audience Network: allow native bids for non-IAB sizes (prebid#2203) Update position default value in rubicon (prebid#2214) Auctionmanager spec refactor pr (prebid#2155) fix mediaType being overwritten by undefined in rubicon bid adapter (prebid#2209) Fix lint error (prebid#2208) VAST support in adform adapter (prebid#2173) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This pull request refactors auctionmanager_spec.js and readds the timeout test that was removed in #2067. By consolidating a lot of duplicated code, I think it's easier to read and modify.