-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SARA-HB Bid Adapter #2172
Add SARA-HB Bid Adapter #2172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SARA-HB Code looks good.
But not receiving bids, i am testing on https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/hello_world.html
To merge i will need Docs PR. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
@jaiminpanchal27 - docs PR is prebid/prebid.github.io#628 |
@SARA-HB Any update ? |
@jaiminpanchal27 Please check the test ids again, we setup a campaign to return bids. |
@SARA-HB Not returning bids again. I tried testing using this page https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/hello_world.html Tried both uid 5 and 6 |
@SARA-HB Any update ? |
Hey @jaiminpanchal27, it seems that in your example HTML you're calling only appnexus for bids. The bids section doesn't contain anything about 'sara'. Could you please check? |
@SARA-HB hello_world is template we use to test all bidders. We update adUnits with the test params. It works now. Thanks |
Type of change
Description of change
New Bidder Adapter for SARA