Skip to content

Legacy #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Legacy #2266

wants to merge 4 commits into from

Conversation

jlzhangdev
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add an adapter so ebdr demand can bid on it.

  • test parameters for validating bids
{
    bidder: 'ebdr',
            params: {
               zoneid: '99999',
               bidfloor: '1.00',
               IDFA:'HelloIDFA',
               ADID:'GoodMorning-ADFA',
               latitude:'34.089811',
               longitude:'-118.392805'
            }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 9b48d2d into 97f2d9d - view on lgtm.com

new alerts:

  • 1 for Superfluous trailing arguments

Comment posted by lgtm.com

@jlzhangdev jlzhangdev closed this Mar 14, 2018
@jlzhangdev jlzhangdev reopened this Mar 14, 2018
@bretg
Copy link
Collaborator

bretg commented Mar 15, 2018

@jlzhangdev - is there a version of this adapter in the main 1.0 branch?

We require that all new adapters be in 1.0 first, then if they pass there, they may be modified to work with 0.x.

@jlzhangdev
Copy link
Contributor Author

We just submit a new pull request for main branch
#2309

@jlzhangdev
Copy link
Contributor Author

Hi @bretg
Our bid adapter for 1.x have been accepted. #2309. Can you provide me more info how do we PR to legacy project. Thanks.

@jlzhangdev jlzhangdev closed this Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants