Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hb_cache_id #2273

Merged
merged 1 commit into from
Mar 19, 2018
Merged

add hb_cache_id #2273

merged 1 commit into from
Mar 19, 2018

Conversation

moonshells
Copy link
Contributor

@moonshells moonshells commented Mar 16, 2018 •
edited
Loading

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

hb_uuid should be deprecated and replaced by hb_cache_id

@snapwich snapwich self-requested a review March 16, 2018 16:03
snapwich
snapwich approved these changes Mar 16, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But are there any implications to this change that need to be addressed? At the very least, some documentation changes I'm guessing.

@bretg bretg requested a review from mkendall07 March 19, 2018 11:30
@bretg bretg mentioned this pull request Mar 19, 2018
Merged
@bretg
Copy link
Collaborator

bretg commented Mar 19, 2018

Docs PR submitted. Merging, and will add a note in the release notes.

@bretg bretg merged commit c314596 into prebid:master Mar 19, 2018
@moonshells moonshells deleted the add_hb_cache_id branch March 19, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@mkendall07 mkendall07

Labels
needs docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moonshells @bretg @snapwich @mkendall07