Added new types of traffic Colossus SSP adapter #2281

HuddledMasses · 2018-03-19T08:20:53Z

Type of change

Feature

Description of change

Added new types of traffic Colossus SSP adapter.

test parameters for validating bids

{
   bidder: 'colossusssp',
   params: {
      placement_id: 0,
      traffic: 'video'
    }
}

contact email of the adapter’s maintainer: support@colossusmediallc.com
official adapter submission

jsnellbaker

Hello @HuddledMasses ,

If you are planning to support video & native, the colossus SSP bidder spec should include

supportedMediaTypes: ['banner', 'video', 'native'],

(below aliases or anywhere in the spec is fine). See this note in the docs for more info on supporting video & native (if you haven't already).

Additionally, can you please also remove the changes to the package-lock.json file from this PR? Thanks!

HuddledMasses · 2018-03-22T09:06:59Z

Hi @jsnellbaker
here is the updated Colossus docs pull request: #680

jsnellbaker · 2018-03-22T19:13:59Z

Hi @HuddledMasses I'm a bit confused, you are planning to support banner, video and native - right?

If so, the docs PR only included the banner support. Shouldn't it also note the video & native support? Also, did you have the chance to look at the recommendations for this PR?

Thanks.

HuddledMasses · 2018-03-26T09:08:34Z

We updated pull request.
Please, review.
@jsnellbaker

jsnellbaker · 2018-03-26T14:13:16Z

Hi @HuddledMasses , thanks for submitting the update. I was trying to test the adapter with the test params included in the PR (for the video ad unit?), but the adapter code wasn't accepting the bid response.

It seems like a banner type unit came back instead of a video type. Further the bid was rejected because it didn't contain a mediaType object in the response, which is needed in the isBidResponseValid() check.

Can you take a look at the test param information/bid response?

Also, if you're going to now support additional ad unit types, I'd like to test each type (banner, video, native) to ensure they're all working successfully with your updated adapter. If you can provide test param info for each ad type, I'd greatly appreciate it.

For reference here is a copy of the bid response I received:
[{"width":300,"height":250,"ad":"<img src='http://supply.huddledmasses.com/img/logo.png' style='position: absolute; left: 50%; top:50%; margin-left: -113px; margin-top:-79px;'>","requestId":"28419cc0d6c5ca","cpm":5,"ttl":120,"creativeId":"123","netRevenue":true,"currency":"USD","dealId":"HASH"}]

HuddledMasses · 2018-03-27T15:25:53Z

Hi @jsnellbaker
I updated the server.
Added test placements.
Banner: {placement_id:0, traffic:"banner"}
Video: {placement_id:0, traffic:"video"}
Native: {placement_id:0, traffic:"native"}
Can you please check?

jsnellbaker · 2018-03-27T16:53:38Z

Hi @HuddledMasses,
Thanks for providing the additional test ad units and making the change on your server.

I tested out each of the ad units; see details/feedback below:

banner: LGTM
video: LGTM
native: needs some additional changes (details below).

When we're receiving a native bid response, certain properties of the native bid response need to be defined in the bid under a native object. These properties are largely the native ad's assets (like image (with url, height, width), clickurl, impressionTrackers, etc). If these properties are not included, the bid is rejected (which is what I was seeing while testing).

The following page has a sample markup for the bid.native object that needs to be populated, as well as some additional information.
http://prebid.org/dev-docs/bidder-adaptor.html#supporting-native

Can you take a look and make the changes? I was using the hello_world.html page for this testing if you want check it on your end as well. Please let me know if you have any questions. We should be good once this last piece is in place and working.

HuddledMasses · 2018-04-10T10:30:17Z

Hi @jsnellbaker
We changed native response validation.
Also changed the formation of the response from the server.
The documentation indicates the ability to set different types of traffic.
https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/colossusssp.md

jsnellbaker · 2018-04-10T18:24:10Z

Hi @HuddledMasses thanks for submitting the changes. Unfortunately, it doesn't seem like the native bid response is being accepted by the internal validation.

The issue seems to boil down to where the native information (clickurl, image object) is being stored. It's currently being added to the bid overall, instead into a native object within the bid.

As an example, this is the current appearance of the bid response object as populated from the adapter:

  "bidderCode": "colossusssp",
  "width": 0,
  "height": 0,
  "statusMessage": "Bid available",
  "adId": "201d8dea935e26",
  "mediaType": "native",
  "source": "client",
  "clickUrl": "http://supply.colossusssp.com",
  "title": "Test",
  "image": {
    "url": "http://supply.colossusssp.com/img/logo.png",
    "width": 226,
    "height": 158
  },
  "impressionTrackers": [
    "colossusssp.com"
  ],
  "ttl": 120,
  "cpm": 0.4,
  "requestId": "201d8dea935e26",
  "creativeId": "2",
  "netRevenue": true,
  "currency": "USD",
  "dealId": "1"
}

It should ideally store the native related information like this:

{
  "bidderCode": "colossusssp",
  "width": 0,
  "height": 0,
  "statusMessage": "Bid available",
  "adId": "201d8dea935e26",
  "mediaType": "native",
  "source": "client",
  "native": {
     "clickUrl": "http://supply.colossusssp.com",
     "title": "Test",
     "image": {
        "url": "http://supply.colossusssp.com/img/logo.png",
        "width": 226,
        "height": 158
      },
      "impressionTrackers": [
          "colossusssp.com"
       ],
   }, 
  "ttl": 120,
  "cpm": 0.4,
  "requestId": "201d8dea935e26",
  "creativeId": "2",
  "netRevenue": true,
  "currency": "USD",
  "dealId": "1"
}

Can you try to make the necessary changes? Please let me know if you have any questions.

HuddledMasses · 2018-04-22T12:53:20Z

Hi @jsnellbaker
We have made changes in the native.
Also added the transfer of data by size to the server.

jsnellbaker · 2018-04-23T17:11:26Z

Hi @HuddledMasses, Thanks again for making the changes.

I tested the native ad unit and found it was structured properly and passing the internal checks. However, ad unit wasn't rendering on the test page. While looking over the browser console, I noticed the pbjs.renderAd function was being executed after we got the bid response.

This is normally used to help render banner and video ads and is invoked from the prebid creative template. The native creative template is different (as it has to handle different creative assets).

The following page gives an outline of what the native creative code looks like: http://prebid.org/adops/setting-up-prebid-native-in-dfp.html

Can you take a look over this page and try to make the needed changes? I believe we should be good to merge after this is addressed. Thanks!

HuddledMasses · 2018-04-24T10:34:57Z

@jsnellbaker
I don't understand.
Where do I need to make changes?
The adapter doesn't affect the operation or sequence of the function call pbjs.renderAd.

jsnellbaker · 2018-04-24T15:12:38Z

@HuddledMasses There should be a creative in your ad server that would return a 'prebid' creative. Normally this creative is a set of JavaScript that makes the call the pbjs.renderAd to render a video or banner creative that's retruned from the auction. In this case for the native, the creative should be setup with a different creative template in the format that was referenced in the page from before (ie plain HTML).

Maybe one of the traffickers or adops people on your end may be able to help point you to the area where the changes need to be made?

If it will help, below is a link to a more parent-level page on the different ways to setup prebid creatives:
http://prebid.org/adops/docs-by-ad-server.html

HuddledMasses · 2018-04-26T12:19:57Z

@jsnellbaker
I don't understand.
What returns the adapter is not correct ? If so you can say what is wrong.
Or a template must be created. If so, then where to add it ?

jsnellbaker · 2018-04-26T18:56:37Z

@HuddledMasses I'm sorry about the confusion on the last point in this PR. I conferred with a colleague and got this straightened out. It seems everything is fine at this point. I'm going to merge in this PR.

* add video&native traffic colossus ssp * Native obj validation * Native obj validation #2 * Added size field in requests * fixed test

HuddledMasses · 2019-09-05T17:32:09Z

Team, can you please let us know why Colossus adapter has not been listed here?

http://prebid.org/dev-docs/bidders.html#bidders-with-video-and-native-demand

jsnellbaker · 2019-09-06T13:12:40Z

Hi @HuddledMasses

To have the bidder appear on that table, you'd need to submit a PR to the Prebid Docs repo (located here) to update this file:
https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/colossusssp.md

Just need to add the following variables to the top section (where the other variables are located):

media_types: banner, video, native

HuddledMasses · 2019-09-16T10:53:10Z

Hi @jsnellbaker
PR has been updated: prebid/prebid.github.io#1484

Please take a look. Thanks!

bretg requested a review from jsnellbaker March 19, 2018 14:20

bretg assigned jsnellbaker Mar 19, 2018

jsnellbaker requested changes Mar 19, 2018

View reviewed changes

jsnellbaker added the needs update label Mar 19, 2018

add video&native traffic colossus ssp

b87237c

HuddledMasses force-pushed the master branch from 61a795e to b87237c Compare March 26, 2018 08:59

mjacobsonny added the needs docs label Mar 27, 2018

Native obj validation

1ca4e28

vladis-teqblaze added 3 commits April 22, 2018 15:31

Native obj validation #2

b5c1850

Added size field in requests

e969f27

fixed test

67693e1

jsnellbaker approved these changes Apr 26, 2018

View reviewed changes

jsnellbaker merged commit 5c14e9c into prebid:master Apr 26, 2018

HuddledMasses mentioned this pull request Sep 5, 2019

Colossus adapter question #4164

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new types of traffic Colossus SSP adapter #2281

Added new types of traffic Colossus SSP adapter #2281

HuddledMasses commented Mar 19, 2018

jsnellbaker left a comment

HuddledMasses commented Mar 22, 2018

jsnellbaker commented Mar 22, 2018

HuddledMasses commented Mar 26, 2018 •

edited

Loading

jsnellbaker commented Mar 26, 2018

HuddledMasses commented Mar 27, 2018

jsnellbaker commented Mar 27, 2018

HuddledMasses commented Apr 10, 2018

jsnellbaker commented Apr 10, 2018 •

edited

Loading

HuddledMasses commented Apr 22, 2018

jsnellbaker commented Apr 23, 2018

HuddledMasses commented Apr 24, 2018

jsnellbaker commented Apr 24, 2018

HuddledMasses commented Apr 26, 2018

jsnellbaker commented Apr 26, 2018

HuddledMasses commented Sep 5, 2019

jsnellbaker commented Sep 6, 2019

HuddledMasses commented Sep 16, 2019 •

edited

Loading

Added new types of traffic Colossus SSP adapter #2281

Added new types of traffic Colossus SSP adapter #2281

Conversation

HuddledMasses commented Mar 19, 2018

Type of change

Description of change

jsnellbaker left a comment

Choose a reason for hiding this comment

HuddledMasses commented Mar 22, 2018

jsnellbaker commented Mar 22, 2018

HuddledMasses commented Mar 26, 2018 • edited Loading

jsnellbaker commented Mar 26, 2018

HuddledMasses commented Mar 27, 2018

jsnellbaker commented Mar 27, 2018

HuddledMasses commented Apr 10, 2018

jsnellbaker commented Apr 10, 2018 • edited Loading

HuddledMasses commented Apr 22, 2018

jsnellbaker commented Apr 23, 2018

HuddledMasses commented Apr 24, 2018

jsnellbaker commented Apr 24, 2018

HuddledMasses commented Apr 26, 2018

jsnellbaker commented Apr 26, 2018

HuddledMasses commented Sep 5, 2019

jsnellbaker commented Sep 6, 2019

HuddledMasses commented Sep 16, 2019 • edited Loading

HuddledMasses commented Mar 26, 2018 •

edited

Loading

jsnellbaker commented Apr 10, 2018 •

edited

Loading

HuddledMasses commented Sep 16, 2019 •

edited

Loading