Sonobi Video Support #2297
Merged
Sonobi Video Support #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eo. So only check if it is a video if sbi_ct exists
rberner
approved these changes
Mar 20, 2018
|
@mjacobsonny Docs PR added. prebid/prebid.github.io#698 |
|
@ndhimehta @jsnellbaker has there been any progress on this? Do you need anything else from Sonobi to get this merged? |
mkendall07
approved these changes
Apr 13, 2018
| const [ | ||
| width = 1, | ||
| height = 1 | ||
| ] = bid.sbi_size.split('x'); |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* added support for setting vastUrl * removed unsed param * some refactoring around detecting the media type and forming the creative * changed let to const * added ref param to sbi.js. fixed lint issues * added video test params to sonobi readme. * sbi_ct only comes back in a trinity response if the creative is a video. So only check if it is a video if sbi_ct exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added support for video and added ref parameter to Sonobi's creative display rendering
Be sure to test the integration with your adserver using the Hello World sample page.
apex.prebid@sonobi.com