-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform.io video support #2318
Conversation
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
Update platformioBidAdapter
Endpoint URL change
Endpoint URL change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @varashellov,
The changes for the video support seem good. However I was running into some trouble when I was retesting the banner and native ad units.
For the banner ad unit, I was seeing a CORS related error message in the console (which is a bit strange since it was only this ad unit that gave this error).
For the native ad unit, I was seeing the POST request to your server go out but nothing came back in the response. The POST completed as a 204.
I was using the hello_world as my test page and I used the testing information in the md file. Would you be able to look into the banner & native? Thanks.
Hello @jsnellbaker |
Hi @varashellov, thanks for providing the sample page. I found the issues I made during the banner and native testing. The ads are delivering fine now. Can you back out the change to the |
@jsnellbaker |
@varashellov Can you just remove the file from the PR entirely? That would be better than uploading the same version of the file. Thanks. |
Hi @varashellov The last commit actually deletes the file instead of removing it from the PR. I checked internally with some other folks, and they actually recommended to just re-add the file back into the PR at this point since it would be the easiest way to fix it. When you have the chance, can you please add the Thanks, and sorry for the back and forth. |
* Add PlatformioBidAdapter * Update platformioBidAdapter.js * Add files via upload * Update hello_world.html * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update hello_world.html * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update hello_world.html * Add files via upload * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Update platformioBidAdapter * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js Endpoint URL change * Update platformioBidAdapter_spec.js Endpoint URL change * Update platformioBidAdapter_spec.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.md * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.md * Update platformioBidAdapter.md * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.md * Add files via upload * Add files via upload * Delete hello_world.html * Add files via upload
Type of change
Description of change
Added support for video