Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform.io video support #2318

Merged
merged 58 commits into from
Mar 30, 2018
Merged

Platform.io video support #2318

merged 58 commits into from
Mar 30, 2018

Conversation

varashellov
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added support for video

  • test parameters for validating bids
  {
    bidder: 'platformio',
    params: {
            pubId: '29521',
            siteId: '26049',
            size: '640X480',
            placementId: '123',
    }
  }
  • contact email of the adapter’s maintainer
  • official adapter submission

@varashellov
Copy link
Contributor Author

Docs prebid/prebid.github.io#688

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @varashellov,
The changes for the video support seem good. However I was running into some trouble when I was retesting the banner and native ad units.

For the banner ad unit, I was seeing a CORS related error message in the console (which is a bit strange since it was only this ad unit that gave this error).

For the native ad unit, I was seeing the POST request to your server go out but nothing came back in the response. The POST completed as a 204.

I was using the hello_world as my test page and I used the testing information in the md file. Would you be able to look into the banner & native? Thanks.

@varashellov
Copy link
Contributor Author

Hello @jsnellbaker
Thanks for the quick response.
Please check hello_world page https://github.com/varashellov/Prebid.js/blob/master/integrationExamples/gpt/hello_world.html

@jsnellbaker
Copy link
Collaborator

Hi @varashellov, thanks for providing the sample page. I found the issues I made during the banner and native testing. The ads are delivering fine now.

Can you back out the change to the hello_world.html page in this PR? We should be good to merge once that's done.

@varashellov
Copy link
Contributor Author

@jsnellbaker
Uploaded the default file
Thanks

@jsnellbaker
Copy link
Collaborator

@varashellov Can you just remove the file from the PR entirely? That would be better than uploading the same version of the file. Thanks.

@jsnellbaker
Copy link
Collaborator

Hi @varashellov The last commit actually deletes the file instead of removing it from the PR. I checked internally with some other folks, and they actually recommended to just re-add the file back into the PR at this point since it would be the easiest way to fix it.

When you have the chance, can you please add the master version of this file to the PR?

Thanks, and sorry for the back and forth.

@jsnellbaker jsnellbaker merged commit 7407a44 into prebid:master Mar 30, 2018
@jsnellbaker jsnellbaker added this to the 1.7 milestone Apr 2, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Add PlatformioBidAdapter

* Update platformioBidAdapter.js

* Add files via upload

* Update hello_world.html

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Update hello_world.html

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update hello_world.html

* Add files via upload

* Update platformioBidAdapter

## Type of change
- [x] Other

## Description of change
1. RequestURL changes
2. Add placementCode to request params

* Update platformioBidAdapter

* Update platformioBidAdapter

## Type of change
- [x] Other

## Description of change
1. RequestURL changes
2. Add placementCode to request params

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.js

Endpoint URL change

* Update platformioBidAdapter_spec.js

Endpoint URL change

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter.md

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.md

* Update platformioBidAdapter.md

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.md

* Add files via upload

* Add files via upload

* Delete hello_world.html

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants