Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unruly Bid Adapter #2326

Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2018

Type of change

  • New bidder adapter

Description of change

Added UnrulyX Bidder Adapter.

  • test parameters for validating bids
   const adUnits = [{
       code: 'ad-slot',
       sizes: [[728, 90], [300, 250]],
       mediaTypes: {
           video: {
               context: 'outstream'
           }
       },
       bids: [{
           bidder: 'unruly',
           params: {
               targetingUUID: '6f15e139-5f18-49a1-b52f-87e5e69ee65e',
               siteId: 1081534
           }
       }
       ]
   }];

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Our devdocs page has been already set up and it's available here: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/unruly.md

Other information

This implementation is a copy of our legacy build which we recently updated to make it 1.0-compatible.

@YOzaz
Copy link

YOzaz commented Apr 12, 2018

Bump!
We need it for 1.x migration as soon as possible...

@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta Apr 13, 2018
@snapwich snapwich self-requested a review April 16, 2018 17:01
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 1557315 into prebid:master Apr 16, 2018
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request Apr 18, 2018
* 'master' of https://github.com/prebid/Prebid.js: (211 commits)
  Increment Pre Version
  Prebid 1.8.0 Release
  Make eslint aware of the custom import paths (prebid#2292)
  send travis-ci notifications to slack (prebid#2404)
  send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351)
  convert AN bid params to underscore formatting for pbs (prebid#2385)
  EbdrAdapter add usersync  (prebid#2407)
  Add outstream renderer to Beachfront adapter (prebid#2403)
  Add analytics adapter by Sigmoid (prebid#2316)
  deprecate loadScript and add loadExternalScript (prebid#2391)
  Removed the ability for to override any standard query parameters (prebid#2402)
  Unit test failures (prebid#2405)
  Add Unruly Bid Adapter (prebid#2326)
  Added VIS.X Bidder Adapter (prebid#2359)
  Smart: Add prebid version in the data payload (prebid#2394)
  add support for video bids to use an impression tracking URL  (prebid#2365)
  Create rtbdemandAdkBidAdapter_spec.js (prebid#2352)
  Widespace adapter (prebid#2283)
  Add: Vuble Analytics Adapter (prebid#2331)
  fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363)
  ...

# Conflicts:
#	test/spec/modules/rockyouBidAdapter_spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants