Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change utils.js unit tests to fix browserstack errors #2337

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Build related changes
  • Other

Description of change

This change fixes some issues we are seeing when running the browserstack tests. In some browsers it seems the port value for these unit tests are either 0 or 443 (like IE and Chrome). So we altered the unit tests to check for both.

@mkendall07 mkendall07 merged commit f2d15b6 into master Apr 3, 2018
@mkendall07 mkendall07 deleted the fix_browserstack_errors_for_1.7_release branch April 3, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants