Support price granularity per mediaType #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 23, 2018 14:09
…2347-support-price-granularity-per-mediatype
mkendall07
requested review from
jaiminpanchal27,
mkendall07 and
snapwich
and removed request for
mkendall07
jaiminpanchal27
approved these changes
Apr 16, 2018
|
@idettman Need docs PR open to merge this |
mkendall07
reviewed
Apr 16, 2018
| set mediaTypePriceGranularity(val) { | ||
| this._mediaTypePriceGranularity = Object.keys(val).reduce((aggregate, item) => { | ||
| if (validatePriceGranularity(val[item])) { | ||
| if (typeof val === 'string') { |
There was a problem hiding this comment.
looks like this code was copied from the function above around line ~90. Can we combine it/make more generic?
There was a problem hiding this comment.
I initially had the logic for both extracted into a generic function, but the added complexity specific for mediaTypesGranularity resulted in more code than inlining with the additional conditionals
|
@idettman |
added 2 commits
May 2, 2018 11:58
…2347-support-price-granularity-per-mediatype
…2347-support-price-granularity-per-mediatype
|
Docs PR at prebid/prebid.github.io#764 -- since it touched the Pub API, combined it with some refactoring. |
mkendall07
approved these changes
May 16, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Add config support for mediaTypePriceGranularity * Update to set default granularity to use config default * Formatting change, comment updated * Formatting change * Added test for mediaTypePriceGranularity enabled * Added test for mediaTypePriceGranularity video type * Changed double quotes to single in config_spec * Linting fixes for indentation and spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for setting price granularity per mediaType.
Use case:
Proposal is to allow the definition of the priceGranularity at a mediaType level:
Other information
https://jira.rubiconproject.com/projects/HB/issues/HB-2347