Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon adapter GDPR support #2406

Merged

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Apr 16, 2018

Type of change

  • Other

Description of change

Updates the Rubicon adapter to:

  • read bidRequest.gdprConsent.consentRequired and pass it through the FastLane URL as gdpr={0 or 1}
  • read bidRequest.gdprConsent.consentString and pass it through the FastLane URL as gdpr_consent=URL_encoded(STRING)
pbjs.setConfig({
  consentManagement: {
    cmp: 'iab',
    waitForConsentTimeout: 4000,
    lookUpFailureResolution: 'cancel'
  }
});

Other information

Documentation update: prebid.github.io #719 | Task HB-2303

@snapwich
Copy link
Collaborator

@idettman This pull-request appears to be pulling in changes not related to GDPR in the file diff. Might need to be rebased.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idettman The adapter file changes look fine. But it seems there are conflicts now in the PR against master.

Can you please review and address the conflicts, as well as comment on Rich's feedback? Thanks.

@jsnellbaker
Copy link
Collaborator

@idettman Also, can you submit a docs-PR to update the Rubicon bidders page with a new variable named gdpr_supported: true? It can go right under the variable for prebid_1_0_supported.

This would allow the Rubicon adapter to show-up automatically on a list we have setup for GDPR supported adapters in the docs. Thanks.

@idettman
Copy link
Contributor Author

@jsnellbaker here's a link to the PR with gdpr_supported change.
Rubicon Adapter Docs Update: prebid.github.io #719

@jsnellbaker
Copy link
Collaborator

@idettman Thanks for submitting the docs PR. When the other Rubicon GDPR PR was merged, it seems like it created some additional conflicts here. Can you please take a look again and see if we can get in sync with master? atm a number of changes look like they're going to be reverted in master if we were to merge as is. Thanks.

@idettman
Copy link
Contributor Author

Merged changes to latest master updates

// add GDPR properties if enabled
if (config.getConfig('consentManagement')) {
if (bidRequest.gdprConsent && typeof bidRequest.gdprConsent === 'object') {
if (typeof bidRequest.gdprConsent.consentRequired === 'boolean') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idettman In the upcoming changes to the consentManagement module, we'll be renaming this field to bidderRequest.gdprConsent.gdprApplies

Can you please make the necessary changes to point to the new field? Please also ensure you're pointing to the bidderRequest object and not the bidRequest object.

As a final request, can you please make the above updates on the earlier set of GDPR code in the adapter file (for the video requests)?

Copy link
Contributor Author

@idettman idettman Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are committed.

Isaac Dettman added 2 commits April 24, 2018 10:08
…hanged containing object used to access gdprConsent values (bidRequest -> bidderRequest)
@jsnellbaker jsnellbaker merged commit 34f34d8 into prebid:master Apr 24, 2018
@nickdima
Copy link

What happens if the consent is not asked to the user? What's the default used by Rubicon?

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Merged gdpr tests for banner bid requests

* Renamed the gdprConsent.consentRequired to gdprConsent.gdprApplies. Changed containing object used to access gdprConsent values (bidRequest -> bidderRequest)
@idettman idettman deleted the rubicon-adapter-gdpr-support branch March 18, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants