Size Bugfix #2414
Merged
Size Bugfix #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # integrationExamples/gpt/hello_world.html # modules/quantumBidAdapter.js # package.json # test/spec/modules/quantumBidAdapter_spec.js
|
Please review. Thank you. |
jsnellbaker
requested changes
Apr 20, 2018
modules/quantumBidAdapter.js
Outdated
| @@ -104,7 +104,8 @@ export const spec = { | |||
| bid.sync = serverBody.sync; | |||
| if (bidRequest.renderMode && bidRequest.renderMode === 'banner') { | |||
| bid.width = 300; | |||
| bid.height = 225; | |||
| bid.height = 250; | |||
There was a problem hiding this comment.
Are you sure you want these height/width values to be hard-coded like this? Wouldn't it be more ideal to read from the bid response object? I thought I saw some height/width params in the response from the server, so I wanted to confirm on this point.
|
You're right. removed response hardcoded sizes. Thank you. |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change