[1.x] Populate crid with values from demand if present #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send 'iv' param if present and full url in `site.page`
Enhance location detection within utils
CR for enhanced-location-detection PR
Reorg gettopwindowlocation util & add tests.
set creativeId to crid if present in response
aprakash-sovrn
changed the title
|
Hi there, has anyone had a chance to take a look at this? Should be a pretty quick review. |
|
@aprakash-sovrn this is slated to be reviewed later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This change adds the creative id to the crid field of bids returned from the sovrn adapter if they are present from demand.
Other information
1.x fix for #2374