added whitelist for loading external JS + tests #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Apr 26, 2018
test/spec/adloader_spec.js
Outdated
| @@ -1,4 +1,32 @@ | |||
| import * as utils from 'src/utils'; | |||
| import { assert } from 'chai'; | |||
There was a problem hiding this comment.
I think this assert is not getting used anywhere
jaiminpanchal27
approved these changes
Apr 26, 2018
jaiminpanchal27
added
LGTM
needs 2nd review
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* added whitelist for loading external JS + tests * fixed import * remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds validation for whitelist, caching and tests.