-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Video Adapter #2445
One Video Adapter #2445
Conversation
Putting in the review queue, but heads-up this also needs a PR against https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders. |
@ankur-modi can you please fill out the description of your submission to have proper params, docs, etc? |
modules/oneVideoBidAdapter.js
Outdated
*/ | ||
buildRequests: function(bids) { | ||
return bids.map(bid => { | ||
console.log(getRequestData(bid)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all debugging information. there shouldn't be any console.log
in the production code (other than through utils.logWarn
, utils.logError
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
const requests = spec.buildRequests([ bidRequest ]); | ||
expect(requests[0].bidRequest).to.equal(bidRequest); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also be validating that the data payload looks correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
One video adapter doc prebid.github.io#739
Other information