Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Video Adapter #2445

Merged
merged 2 commits into from
May 4, 2018
Merged

One Video Adapter #2445

merged 2 commits into from
May 4, 2018

Conversation

ankur-modi
Copy link
Contributor

@ankur-modi ankur-modi commented Apr 23, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'oneVideo',
            params: {
              video: {
                playerWidth: 480,
                playerHeight: 640,
                mimes: ['video/mp4', 'application/javascript'],
                protocols: [2,5],
                api: [2],
                position: 1,
                delivery: [2]
              },
              site: {
                id: 1,
                page: 'http://abhi12345.com',
                referrer: 'http://abhi12345.com'
              },
              pubId: 'brxd'
            }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg
Copy link
Collaborator

bretg commented Apr 26, 2018

Putting in the review queue, but heads-up this also needs a PR against https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders.

@snapwich
Copy link
Collaborator

snapwich commented May 1, 2018

@ankur-modi can you please fill out the description of your submission to have proper params, docs, etc?

*/
buildRequests: function(bids) {
return bids.map(bid => {
console.log(getRequestData(bid));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all debugging information. there shouldn't be any console.log in the production code (other than through utils.logWarn, utils.logError, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

const requests = spec.buildRequests([ bidRequest ]);
expect(requests[0].bidRequest).to.equal(bidRequest);
});
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also be validating that the data payload looks correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 3116d7f into prebid:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants