Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update babel plugins #2447

Merged
merged 2 commits into from
May 7, 2018
Merged

Update babel plugins #2447

merged 2 commits into from
May 7, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Refactoring (no functional changes, no api changes)
  • Build related changes

Description of change

  • Added babel-preset-env which replaces es2015, es2016, es2017 and latest.
  • Removed some babel plugins which were required for IE8 IE9 which we don't support anymore.
  • Tested babel-runtime-transform to add ES6 features without polluting global namespace but it adds some 20kb to prebid core and hence not part of this PR.
  • Removed duplicate babel config from webpack conf. babel-loader uses .babelrc as default

mkendall07
mkendall07 approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this impact the build size at all?

@jaiminpanchal27
Copy link
Collaborator Author

@mkendall07 No it does not add increase the size
Tested by building prebid with appnexusBidAdapter and its 90kb for both.

@jaiminpanchal27 jaiminpanchal27 added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Apr 26, 2018
@snapwich
Copy link
Collaborator

@jaiminpanchal27 shouldn't we specify our targets as described here? Otherwise it seems to just include everything

@mkendall07
Copy link
Member

@jaiminpanchal27 ?

snapwich
snapwich approved these changes May 4, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaiminpanchal27 jaiminpanchal27 merged commit cf1dc79 into master May 7, 2018
@jaiminpanchal27 jaiminpanchal27 mentioned this pull request Jun 5, 2018
Closed
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@jaiminpanchal27 @dluxemburg
Update babel plugins (prebid#2447)
00c85d8 
* Update babel plugins

* Targeting browsers
@mkendall07 mkendall07 deleted the babel-updates branch August 17, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees
No one assigned
Labels
in progress needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaiminpanchal27 @snapwich @mkendall07