Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Release Process #2451

Merged
merged 5 commits into from
May 17, 2018
Merged

Added Release Process #2451

merged 5 commits into from
May 17, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Other

Description of change

Adding Release Steps and Updated readme to remove command to run single test

@bretg
Copy link
Collaborator

bretg commented Apr 26, 2018

There's not a prebid-org browserstack is there?

How about updating the download page?

# FAQs
## Release Process

1. Make Sure all browserstack tests are passing. Check the last travis build for master branch. If failing please fix the failing tests or skip the test and create issue if it takes too long to fix the failed unit test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+tag contributor.


3. Publish Release

Make sure your Prebid code is clean and up to date
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this step mean? NPM? should include specifics.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on mkendall07's question

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just verifying that there are no more merges to master in between the process. Updated the step.

@jaiminpanchal27
Copy link
Collaborator Author

@bretg We do have Browserstack account for Prebid.org. Browserstack Travis integration is currently using that.
For Download page, @mkendall07 can you tell if that can be added to these steps here.


1. Make Sure all browserstack tests are passing. Check the last travis build for master branch. If failing please fix the failing tests or skip the test and create issue if it takes too long to fix the failed unit test.

#### How to run tests in browserstack
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the coordinator need to run the tests manually or can they just look at the latest travis build? Row 19 says to check Travis -- do we just re-run the tests anyhow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more details.


3. Publish Release

Make sure your Prebid code is clean and up to date
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on mkendall07's question


Pull these changes locally

5. Update coveralls
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could note that coveralls is a code-coverage tool

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Edit the most recent release notes draft and make sure the correct tag is in the dropdown. Click `Publish`. GitHub will create release tag.

Pull these changes locally
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the release notes to your local machine? Unclear why that's needed.

Copy link
Collaborator Author

@jaiminpanchal27 jaiminpanchal27 May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify the tag added automatically by github


gulp test --browserstack >> prebid_test.log

vim prebid_test.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we looking for at this step?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of unit tests. Added comment

git commit -m "Increment pre version"
git push
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a note about updating the Download page.

@jaiminpanchal27
Copy link
Collaborator Author

@bretg @mkendall07 Have updated the steps.

@stale
Copy link

stale bot commented May 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 16, 2018
@stale stale bot removed the stale label May 17, 2018
@mkendall07 mkendall07 merged commit 10f923e into master May 17, 2018
@mkendall07 mkendall07 deleted the release-process branch May 17, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants