-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Release Process #2451
Added Release Process #2451
Conversation
There's not a prebid-org browserstack is there? How about updating the download page? |
RELEASE_SCHEDULE.md
Outdated
# FAQs | ||
## Release Process | ||
|
||
1. Make Sure all browserstack tests are passing. Check the last travis build for master branch. If failing please fix the failing tests or skip the test and create issue if it takes too long to fix the failed unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+tag contributor.
RELEASE_SCHEDULE.md
Outdated
|
||
3. Publish Release | ||
|
||
Make sure your Prebid code is clean and up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this step mean? NPM? should include specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on mkendall07's question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its just verifying that there are no more merges to master in between the process. Updated the step.
@bretg We do have Browserstack account for Prebid.org. Browserstack Travis integration is currently using that. |
RELEASE_SCHEDULE.md
Outdated
|
||
1. Make Sure all browserstack tests are passing. Check the last travis build for master branch. If failing please fix the failing tests or skip the test and create issue if it takes too long to fix the failed unit test. | ||
|
||
#### How to run tests in browserstack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the coordinator need to run the tests manually or can they just look at the latest travis build? Row 19 says to check Travis -- do we just re-run the tests anyhow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more details.
RELEASE_SCHEDULE.md
Outdated
|
||
3. Publish Release | ||
|
||
Make sure your Prebid code is clean and up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on mkendall07's question
RELEASE_SCHEDULE.md
Outdated
|
||
Pull these changes locally | ||
|
||
5. Update coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could note that coveralls is a code-coverage tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
RELEASE_SCHEDULE.md
Outdated
|
||
Edit the most recent release notes draft and make sure the correct tag is in the dropdown. Click `Publish`. GitHub will create release tag. | ||
|
||
Pull these changes locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull the release notes to your local machine? Unclear why that's needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To verify the tag added automatically by github
RELEASE_SCHEDULE.md
Outdated
|
||
gulp test --browserstack >> prebid_test.log | ||
|
||
vim prebid_test.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we looking for at this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of unit tests. Added comment
git commit -m "Increment pre version" | ||
git push | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding a note about updating the Download page.
@bretg @mkendall07 Have updated the steps. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Type of change
Description of change
Adding Release Steps and Updated readme to remove command to run single test