OpenX Adapter: Support out of order bids. #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Apr 27, 2018
| .find(key => !(key in contract)); | ||
|
|
||
| if (invalidKey) { | ||
| throw new Error(`Mock Error: INVALID_KEY. Key:${invalidKey} does not exist in type: ${typeName}`); |
There was a problem hiding this comment.
This will stop execution of further unit tests. Wrap all calls to overrideKeyCheck in try..catch
There was a problem hiding this comment.
@jaiminpanchal27, I've switched to using an assertion instead, which throws an AssertionError. I tested it when the keys are invalid and the beforeEach block catches the exception properly and continues on the other tests.
added 2 commits
April 27, 2018 10:22
…hich throws an AssertionError, so that it will be caught properly by test suite when an invalid override is provided.
jimee02
force-pushed
the
single-request-idx-support
branch
from
336eba9 to
56bd6f4
Compare
jaiminpanchal27
approved these changes
May 1, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* OpenX Adapter: Support out of order bids. * OpenX Adapter Spec: Updated overrideKeyCheck to use Chai assertion, which throws an AssertionError, so that it will be caught properly by test suite when an invalid override is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Feature
Added "idx" (index) so that we can return out of order bids will properly map back to request objects.
https://github.com/prebid/Prebid.js/pull/2452/files#diff-2051ef6e55abda4fed56905b5982884aR76
Refactor
Broke down unit tests and re-ordered them such that test suites will be more readable.
Added helper functions to generate cleaner bid response objects.