Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Platformio Adapter #2468

Merged
merged 62 commits into from
May 3, 2018
Merged

Update Platformio Adapter #2468

merged 62 commits into from
May 3, 2018

Conversation

varashellov
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added to request:

imp.secure, 
app.id, app.name, app.bundle, app.storeurl, app.domain,
device.dnt, device.geo, device.ifa
  • test parameters for validating bids
{
    bidder: 'platformio',
    params: {
        pubId: '29521',
        siteId: '26049',
        size: '300X250',
        placementId: '123',
        bidfloor: '0.001',
        ifa: 'IFA',
        latitude: '40.712775',
        longitude: '-74.005973'
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker jsnellbaker self-assigned this Apr 30, 2018
@jsnellbaker jsnellbaker self-requested a review April 30, 2018 13:04
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @varashellov, the changes to the files look good to me. If you are going to support additional fields in your params, can you please update the platformioBidAdapter.md file in this repo and your bidders page in the docs repo? Thanks.

@varashellov
Copy link
Contributor Author

Hi @jsnellbaker, thanks for the quick response.
Pull request prebid/prebid.github.io#743

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 59db2fe into prebid:master May 3, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Add PlatformioBidAdapter

* Update platformioBidAdapter.js

* Add files via upload

* Update hello_world.html

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Update hello_world.html

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update hello_world.html

* Add files via upload

* Update platformioBidAdapter

## Type of change
- [x] Other

## Description of change
1. RequestURL changes
2. Add placementCode to request params

* Update platformioBidAdapter

* Update platformioBidAdapter

## Type of change
- [x] Other

## Description of change
1. RequestURL changes
2. Add placementCode to request params

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.js

Endpoint URL change

* Update platformioBidAdapter_spec.js

Endpoint URL change

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.js

* Update platformioBidAdapter.md

* Add files via upload

* Add files via upload

* Add files via upload

* Update platformioBidAdapter.md

* Update platformioBidAdapter.md

* Update platformioBidAdapter.js

* Update platformioBidAdapter_spec.js

* Update platformioBidAdapter.md

* Add files via upload

* Add files via upload

* Delete hello_world.html

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants