-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Adapter - SRA support #2478
Rubicon Adapter - SRA support #2478
Conversation
@idettman There's a merge conflict. Can you resolve it? |
The test parameters for validating bids are missing closing brackets under parameters structure. All three have the missing bracket I'm not getting bids back with them either Response:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflict.
This change is large enough that it should be validated with working test parameters but I'm not getting bids back on the test params
I did not see any code issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mike-chowla regarding your comment on working test params: unfortunately our endpoint will not be able to handle SRA requests until after the Prebid release, we're merging with a feature that is off by default, so it shouldn't cause issues with existing since it has to be enabled though config. We have tested internally with integration tests so we're confident the code change isn't a breaking change. |
Type of change
Description of change
Adds "Single Request Architecture" (SRA) support to the Rubicon Adapter.
Other information
HB-2542