Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharethrough: GDPR compliance + getUserSyncs #2503

Merged
merged 1 commit into from
May 8, 2018
Merged

Sharethrough: GDPR compliance + getUserSyncs #2503

merged 1 commit into from
May 8, 2018

Conversation

chriscpan
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

  • Passes the GDPR consent string over to Sharethrough's ad server in buildResponse.
  • Adds pixel syncing in getUserSyncs.
  • Fixes a small edge case for our ad server response in interpretResponse.

@harpere harpere self-assigned this May 8, 2018
harpere
harpere approved these changes May 8, 2018
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere added the LGTM label May 8, 2018
@harpere harpere merged commit ea91035 into prebid:master May 8, 2018
@ptim
Copy link
Contributor

ptim commented May 18, 2018

heads up - this is missing from the docs :) @chriscpan

@madma madma deleted the cp/str-gdpr-compliance branch November 25, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

Assignees

@harpere harpere

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscpan @ptim @harpere