Add GDPR parameters in ad request #2522
Conversation
Conflicts: src/adapters/stickyadstv.js test/spec/adapters/stickyadstv_spec.js
modules/freewheelSSPBidAdapter.js
Outdated
| @@ -223,6 +223,20 @@ export const spec = { | |||
| componentId: getComponentId(currentBidRequest.params.format) | |||
| }; | |||
|
|
|||
| if (typeof currentBidRequest.params.gdpr !== 'undefined') { | |||
There was a problem hiding this comment.
this wasn't done properly. buildRequests(bidRequests, bidderRequest) has a second bidderRequest argument where you'll find the gdpr params. please see the doc.
There was a problem hiding this comment.
also, more specifically, I believe gdpr_consent could exist while gdpr is undefined. So checking gdpr !== 'undefined' is not a good way to do this.
There was a problem hiding this comment.
Thx, I'll have a look.
There was a problem hiding this comment.
Changes have been made, thx again.
modules/freewheelSSPBidAdapter.js
Outdated
|
|
||
| var vastParams = currentBidRequest.params.vastUrlParams; | ||
| if (typeof vastParams === 'object') { | ||
| for (kye in vastParams) { |
There was a problem hiding this comment.
Seems to be a small typo here; believe it should be key
modules/freewheelSSPBidAdapter.js
Outdated
| requestParams._fw_gdpr_consent = bidderRequest.gdprConsent.consentString; | ||
|
|
||
| if (typeof currentBidRequest.gdprConsent.gdprApplies === 'boolean') { | ||
| requestParams._fw_gdpr = currentBidRequest.gdprConsent.gdprApplies; |
There was a problem hiding this comment.
Should update currentBidRequest to bidderRequest in these two lines of code.
|
This pull request introduces 1 alert when merging 2a18f58 into 71503a7 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
modules/freewheelSSPBidAdapter.js
Outdated
|
|
||
| var vastParams = currentBidRequest.params.vastUrlParams; | ||
| if (typeof vastParams === 'object') { | ||
| for (key in vastParams) { |
There was a problem hiding this comment.
Update - I thought this was addressed in the commit, but it seems it wasn't. The LGTM check noted this key variable isn't properly declared (missing a let). Could you update this spot?
|
@guillaume-sticky Please submit a docs PR in the docs repo and make an update in your bidders page to add the following variable. This can go directly below the variable for your 1.0 compliance. This will allow your adapter to appear in a table that shows GDPR compliant adapters. Thanks. |
|
will do. Thx! |
Type of change
Description of change
Add some parameters support for freewheel-ssp bidder adapter.
Especially GDPR parameters to be transmit to our ad server
contact email of the adapter’s maintainer
gandouard@freewheel.tv
[ *] official adapter submission