Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix endpoint for brainy #2534

Merged
merged 3 commits into from
May 18, 2018
Merged

Fix endpoint for brainy #2534

merged 3 commits into from
May 18, 2018

Conversation

k-misio
Copy link
Contributor

@k-misio k-misio commented May 15, 2018 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

@jsnellbaker jsnellbaker self-assigned this May 15, 2018
jsnellbaker
jsnellbaker requested changes May 15, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brainymisio, I was testing out the adapter with the new endpoint, but I was encountering a CORS error when the request went out. Would you be able to look into this issue?

Once the adapter is working for test delivery, we should good to merge.

@k-misio
Copy link
Contributor Author

k-misio commented May 16, 2018

@jsnellbaker Thanks for the review.
I will check it, so please wait for a while.

@k-misio
Copy link
Contributor Author

k-misio commented May 17, 2018

@jsnellbaker I fixed all bugs about CORS error.
Please review it and let me know.

jsnellbaker
jsnellbaker approved these changes May 18, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brainymisio Thanks for making the CORS change, it's working now.

@jsnellbaker jsnellbaker merged commit b9ee826 into prebid:master May 18, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@dluxemburg
Fix endpoint for brainy (prebid#2534)
3e087fe 
* Fix endpoint

* Correction corresponding to CORS

* Revert "Correction corresponding to CORS"

This reverts commit 1683291.
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
Fix endpoint for brainy (prebid#2534)
a754ab9 
* Fix endpoint

* Correction corresponding to CORS

* Revert "Correction corresponding to CORS"

This reverts commit 1683291.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-misio @jsnellbaker