Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-format ad unit support to Beachfront adapter #2541

Merged
merged 4 commits into from
May 18, 2018

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented May 15, 2018

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Adds scoped bidder params for video and banner so that bid requests can be sent for both formats. Previously, only a video bid request would be sent for an ad unit that declared support for video and banner.

    var adUnits = [
        {
            code: 'test-video-banner',
            mediaTypes: {
                video: {
                    context: 'instream',
                    playerSize: [ 640, 360 ]
                },
                banner: {
                    sizes: [ 300, 250 ]
                }
            },
            bids: [
                {
                    bidder: 'beachfront',
                    params: {
                        video: {
                            bidfloor: 0.01,
                            appId: '11bc5dd5-7421-4dd8-c926-40fa653bec76',
                            mimes: [ 'video/mp4', 'application/javascript' ]
                        },
                        banner: {
                            bidfloor: 0.01,
                            appId: '3b16770b-17af-4d22-daff-9606bdf2c9c3'
                        }
                    }
                }
            ]
        }
    ];

prebid/prebid.github.io#763

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit ce367d1 into prebid:master May 18, 2018
@jsalis jsalis deleted the multi-format-ad-units branch May 18, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants